Flent-users discussion archives
 help / color / mirror / Atom feed
* Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)
       [not found] <tohojo/flent/pull/200@github.com>
@ 2020-03-10 10:21 ` Toke Høiland-Jørgensen
  2020-03-10 13:30 ` Toke Høiland-Jørgensen
  2020-03-10 14:23 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-03-10 10:21 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]

tohojo requested changes on this pull request.

Happy to take this, but please fix the cutoff issue :)

> @@ -56,6 +56,14 @@ PLOTS = o([
                   'smoothing': 10,
                   'color': 'black',
                   'linewidth': 2}]}),
+    ('upload_box',
+     {'description': 'Upload box plot',
+      'type': 'box',
+      'series': [{'data': glob('TCP upload::*'),
+                  'label': 'BE'},
+                 {'data': 'TCP upload avg',
+                  'label': 'Avg',
+                  'cutoff': (DELAY,-DELAY)}]}),

Shouldn't cutoff be consistent between the average and the individual flows?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#pullrequestreview-371828021

[-- Attachment #1.2: Type: text/html, Size: 2550 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)
       [not found] <tohojo/flent/pull/200@github.com>
  2020-03-10 10:21 ` [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200) Toke Høiland-Jørgensen
@ 2020-03-10 13:30 ` Toke Høiland-Jørgensen
  2020-03-10 14:23 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-03-10 13:30 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 460 bytes --]

Pete Heist <notifications@github.com> writes:

> Should be fixed. I admit that I haven't actually tested with a cutoff,
> but the plot works...

The plot will work in any case (as in it'll display something); it's
just a matter of which subset of data will be part of it :)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#issuecomment-597086503

[-- Attachment #1.2: Type: text/html, Size: 1875 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)
       [not found] <tohojo/flent/pull/200@github.com>
  2020-03-10 10:21 ` [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200) Toke Høiland-Jørgensen
  2020-03-10 13:30 ` Toke Høiland-Jørgensen
@ 2020-03-10 14:23 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-03-10 14:23 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]

Merged #200 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#event-3114932183

[-- Attachment #1.2: Type: text/html, Size: 1956 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-10 14:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tohojo/flent/pull/200@github.com>
2020-03-10 10:21 ` [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200) Toke Høiland-Jørgensen
2020-03-10 13:30 ` Toke Høiland-Jørgensen
2020-03-10 14:23 ` Toke Høiland-Jørgensen

Flent-users discussion archives

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.flent.org/flent-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 flent-users flent-users/ https://lists.flent.org/flent-users \
		flent-users@flent.org
	public-inbox-index flent-users

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git