From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.4 Received: from mail.toke.dk by mail.toke.dk with LMTP id ljPUJlxqZ16O8BIAOr1fkg (envelope-from ) for ; Tue, 10 Mar 2020 11:22:20 +0100 Authentication-Results: mail.toke.dk; none (SPF check N/A for local connections - client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=ScNDiXw4 Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id 7CEF4710275 for ; Tue, 10 Mar 2020 11:22:18 +0100 (CET) Received: from [::1] (port=54940 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.92) (envelope-from ) id 1jBc1h-00Dbpz-4M; Tue, 10 Mar 2020 12:22:17 +0200 Received: from out-16.smtp.github.com ([192.30.254.199]:54245) by web6.sd.eurovps.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jBc1W-00Dbl2-AY for flent-users@flent.org; Tue, 10 Mar 2020 12:22:12 +0200 Date: Tue, 10 Mar 2020 03:21:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583835685; bh=5samQNOjNj3mYyaRXkpGra+VDZzrSg8/nN5EV+IIPps=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ScNDiXw4b1CQV4J3c/nj5qcXIc59OtxPfJMrPoQMTdQ+CTkIsnkKEqI1DGzp7Jmwk XU7IY/GHs6ZgvtfLS3VPSeiON0cH6UEnkXTgk/pEyeWVKCQNKfK9PXTFSZES1Y8Cxw E0QEd8FoHpvea0R3OPSm8PPrn+za0s6Ayv9FkFz0= From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.29 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Subscribed Content-Type: multipart/mixed; boundary="===============1256284343994790124==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============1256284343994790124== Content-Type: multipart/alternative; boundary="--==_mimepart_5e676a252699a_77e13fd44b0cd960269940"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5e676a252699a_77e13fd44b0cd960269940 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit tohojo requested changes on this pull request. Happy to take this, but please fix the cutoff issue :) > @@ -56,6 +56,14 @@ PLOTS = o([ 'smoothing': 10, 'color': 'black', 'linewidth': 2}]}), + ('upload_box', + {'description': 'Upload box plot', + 'type': 'box', + 'series': [{'data': glob('TCP upload::*'), + 'label': 'BE'}, + {'data': 'TCP upload avg', + 'label': 'Avg', + 'cutoff': (DELAY,-DELAY)}]}), Shouldn't cutoff be consistent between the average and the individual flows? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/200#pullrequestreview-371828021 ----==_mimepart_5e676a252699a_77e13fd44b0cd960269940 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo requested changes on this pull request.

Happy to take this, but please fix the cutoff issue :)

In flent/tests/tcp_nup.conf:

> @@ -56,6 +56,14 @@ PLOTS = o([
                   'smoothing': 10,
                   'color': 'black',
                   'linewidth': 2}]}),
+    ('upload_box',
+     {'description': 'Upload box plot',
+      'type': 'box',
+      'series': [{'data': glob('TCP upload::*'),
+                  'label': 'BE'},
+                 {'data': 'TCP upload avg',
+                  'label': 'Avg',
+                  'cutoff': (DELAY,-DELAY)}]}),

Shouldn't cutoff be consistent between the average and the individual flows?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5e676a252699a_77e13fd44b0cd960269940-- --===============1256284343994790124== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============1256284343994790124==--