Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)

Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)

[Toke Høiland-Jørgensen]

[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]

tohojo requested changes on this pull request.

Happy to take this, but please fix the cutoff issue :)

> @@ -56,6 +56,14 @@ PLOTS = o([
                   'smoothing': 10,
                   'color': 'black',
                   'linewidth': 2}]}),
+    ('upload_box',
+     {'description': 'Upload box plot',
+      'type': 'box',
+      'series': [{'data': glob('TCP upload::*'),
+                  'label': 'BE'},
+                 {'data': 'TCP upload avg',
+                  'label': 'Avg',
+                  'cutoff': (DELAY,-DELAY)}]}),

Shouldn't cutoff be consistent between the average and the individual flows?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#pullrequestreview-371828021

[-- Attachment #1.2: Type: text/html, Size: 2550 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)

[Toke Høiland-Jørgensen]

[-- Attachment #1.1: Type: text/plain, Size: 460 bytes --]

Pete Heist <notifications@github.com> writes:

> Should be fixed. I admit that I haven't actually tested with a cutoff,
> but the plot works...

The plot will work in any case (as in it'll display something); it's
just a matter of which subset of data will be part of it :)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#issuecomment-597086503

[-- Attachment #1.2: Type: text/html, Size: 1875 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)

[Toke Høiland-Jørgensen]

[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]

Merged #200 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#event-3114932183

[-- Attachment #1.2: Type: text/html, Size: 1956 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org