From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)
Date: Tue, 10 Mar 2020 03:21:25 -0700 [thread overview]
Message-ID: <tohojo/flent/pull/200/review/371828021@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/200@github.com>
[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]
tohojo requested changes on this pull request.
Happy to take this, but please fix the cutoff issue :)
> @@ -56,6 +56,14 @@ PLOTS = o([
'smoothing': 10,
'color': 'black',
'linewidth': 2}]}),
+ ('upload_box',
+ {'description': 'Upload box plot',
+ 'type': 'box',
+ 'series': [{'data': glob('TCP upload::*'),
+ 'label': 'BE'},
+ {'data': 'TCP upload avg',
+ 'label': 'Avg',
+ 'cutoff': (DELAY,-DELAY)}]}),
Shouldn't cutoff be consistent between the average and the individual flows?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/200#pullrequestreview-371828021
[-- Attachment #1.2: Type: text/html, Size: 2550 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
next parent reply other threads:[~2020-03-10 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tohojo/flent/pull/200@github.com>
2020-03-10 10:21 ` Toke Høiland-Jørgensen [this message]
2020-03-10 13:30 ` Toke Høiland-Jørgensen
2020-03-10 14:23 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tohojo/flent/pull/200/review/371828021@github.com \
--to=notifications@github.com \
--cc=flent@noreply.github.com \
--cc=reply+AHVNJP4QDG7X2NGGBDHZDGV4ONFSLEVBNHHCE5H2YU@reply.github.com \
--cc=subscribed@noreply.github.com \
--subject='Re: [Flent-users] [tohojo/flent] tests: Add tcp_delivery_with_rtt and upload_box plots. (#200)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox