Flent-users discussion archives
 help / color / mirror / Atom feed
* Re: [Flent-users] [tohojo/flent] Install instructions for macOS (#208)
       [not found] <tohojo/flent/pull/208@github.com>
@ 2020-05-30 10:24 ` Toke Høiland-Jørgensen
  2020-06-01  8:47 ` Toke Høiland-Jørgensen
  2020-06-01  8:51 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-30 10:24 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]

@tohojo requested changes on this pull request.

Please drop those two lines, and squash everything into a single commit - other than that, LGTM :)

> +  
+    .. code-block:: bash
+
+        cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+  `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+  
+  You can install Python 3 easily using homebrew
+  
+    .. code-block:: bash
+
+      brew install python
+  
+  A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup

I think we should just drop this line - it's more mystifying than useful...

> +  
+    .. code-block:: bash
+
+        cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+  `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+  
+  You can install Python 3 easily using homebrew
+  
+    .. code-block:: bash
+
+      brew install python
+  
+  A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup

As above

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/208#pullrequestreview-421395202

[-- Attachment #1.2: Type: text/html, Size: 2566 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Flent-users] [tohojo/flent] Install instructions for macOS (#208)
       [not found] <tohojo/flent/pull/208@github.com>
  2020-05-30 10:24 ` [Flent-users] [tohojo/flent] Install instructions for macOS (#208) Toke Høiland-Jørgensen
@ 2020-06-01  8:47 ` Toke Høiland-Jørgensen
  2020-06-01  8:51 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-06-01  8:47 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 247 bytes --]

@tohojo approved this pull request.

Great, thanks! :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/208#pullrequestreview-421686330

[-- Attachment #1.2: Type: text/html, Size: 1188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Flent-users] [tohojo/flent] Install instructions for macOS (#208)
       [not found] <tohojo/flent/pull/208@github.com>
  2020-05-30 10:24 ` [Flent-users] [tohojo/flent] Install instructions for macOS (#208) Toke Høiland-Jørgensen
  2020-06-01  8:47 ` Toke Høiland-Jørgensen
@ 2020-06-01  8:51 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-06-01  8:51 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]

Merged #208 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/208#event-3392154367

[-- Attachment #1.2: Type: text/html, Size: 1449 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-01  8:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tohojo/flent/pull/208@github.com>
2020-05-30 10:24 ` [Flent-users] [tohojo/flent] Install instructions for macOS (#208) Toke Høiland-Jørgensen
2020-06-01  8:47 ` Toke Høiland-Jørgensen
2020-06-01  8:51 ` Toke Høiland-Jørgensen

Flent-users discussion archives

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.flent.org/flent-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 flent-users flent-users/ https://lists.flent.org/flent-users \
		flent-users@flent.org
	public-inbox-index flent-users

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git