From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.toke.dk X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.4 Received: from mail.toke.dk by mail.toke.dk with LMTP id sgPzMH000l7gDgUAOr1fkg (envelope-from ) for ; Sat, 30 May 2020 12:25:01 +0200 Authentication-Results: mail.toke.dk; spf=pass (mailfrom) smtp.mailfrom=flent.org (client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=ly9G7OMV Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id 9D77F7453DA for ; Sat, 30 May 2020 12:24:58 +0200 (CEST) Received: from [::1] (port=43282 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.93) (envelope-from ) id 1jeyfh-0000rk-OS; Sat, 30 May 2020 13:24:57 +0300 Received: from out-24.smtp.github.com ([192.30.252.207]:32863) by web6.sd.eurovps.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jeyfb-0000mj-De for flent-users@flent.org; Sat, 30 May 2020 13:24:56 +0300 Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id 6DAEC6A05A5 for ; Sat, 30 May 2020 03:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590834250; bh=TNF0lHgEFVMX+cL4cFRSlcnOzmQghf+ALsDF6K5ta/o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ly9G7OMVIDU+mvG0yeKkqvK50qxlQAb8DA6eRc6sFKvHbJRpumpQU4MJe7ZDQqQ7w aEFpeMiyGAUSoLOTr/KvpHq2TZ8F3+BKSd38SU6n3pehw1hX/TAjHhdQZ9EwOqovbG 0CAUFr5qH4d82RjmadYddg5gBcA+lgQbMjtkHTAo= Date: Sat, 30 May 2020 03:24:10 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: Re: [Flent-users] [tohojo/flent] Install instructions for macOS (#208) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.29 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Subscribed Content-Type: multipart/mixed; boundary="===============7327187489765312457==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============7327187489765312457== Content-Type: multipart/alternative; boundary="--==_mimepart_5ed2344a5d58e_3cbc3fda46ccd96c5281dd"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5ed2344a5d58e_3cbc3fda46ccd96c5281dd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @tohojo requested changes on this pull request. Please drop those two lines, and squash everything into a single commit - other than that, LGTM :) > + + .. code-block:: bash + + cd /usr/ports/net/flent && make install + +- **macOS:** + + `Homebrew `_ and Python 3 must be installed + + You can install Python 3 easily using homebrew + + .. code-block:: bash + + brew install python + + A more preferred way to install Python on macOS is to use `pyenv `_, but this requires a bit more work to setup I think we should just drop this line - it's more mystifying than useful... > + + .. code-block:: bash + + cd /usr/ports/net/flent && make install + +- **macOS:** + + `Homebrew `_ and Python 3 must be installed + + You can install Python 3 easily using homebrew + + .. code-block:: bash + + brew install python + + A more preferred way to install Python on macOS is to use `pyenv `_, but this requires a bit more work to setup As above -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/208#pullrequestreview-421395202 ----==_mimepart_5ed2344a5d58e_3cbc3fda46ccd96c5281dd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo requested changes on this pull request.

Please drop those two lines, and squash everything into a single commit - other than that, LGTM :)

In README.rst:

> +  
+    .. code-block:: bash
+
+        cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+  `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+  
+  You can install Python 3 easily using homebrew
+  
+    .. code-block:: bash
+
+      brew install python
+  
+  A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup

I think we should just drop this line - it's more mystifying than useful...

In doc/quickstart.rst:

> +  
+    .. code-block:: bash
+
+        cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+  `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+  
+  You can install Python 3 easily using homebrew
+  
+    .. code-block:: bash
+
+      brew install python
+  
+  A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup

As above

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5ed2344a5d58e_3cbc3fda46ccd96c5281dd-- --===============7327187489765312457== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============7327187489765312457==--