From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] Install instructions for macOS (#208)
Date: Sat, 30 May 2020 03:24:10 -0700 [thread overview]
Message-ID: <tohojo/flent/pull/208/review/421395202@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/208@github.com>
[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]
@tohojo requested changes on this pull request.
Please drop those two lines, and squash everything into a single commit - other than that, LGTM :)
> +
+ .. code-block:: bash
+
+ cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+ `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+
+ You can install Python 3 easily using homebrew
+
+ .. code-block:: bash
+
+ brew install python
+
+ A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup
I think we should just drop this line - it's more mystifying than useful...
> +
+ .. code-block:: bash
+
+ cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+ `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+
+ You can install Python 3 easily using homebrew
+
+ .. code-block:: bash
+
+ brew install python
+
+ A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup
As above
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/208#pullrequestreview-421395202
[-- Attachment #1.2: Type: text/html, Size: 2566 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
next parent reply other threads:[~2020-05-30 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tohojo/flent/pull/208@github.com>
2020-05-30 10:24 ` Toke Høiland-Jørgensen [this message]
2020-06-01 8:47 ` Toke Høiland-Jørgensen
2020-06-01 8:51 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tohojo/flent/pull/208/review/421395202@github.com \
--to=notifications@github.com \
--cc=flent@noreply.github.com \
--cc=reply+AHVNJPZTAUS3TE5M7LZ75HF43YKUVEVBNHHCK2FTTU@reply.github.com \
--cc=subscribed@noreply.github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox