Re: [Flent-users] [tohojo/flent] Install instructions for macOS (#208)

["Toke Høiland-Jørgensen" <notifications@github.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]

@tohojo requested changes on this pull request.

Please drop those two lines, and squash everything into a single commit - other than that, LGTM :)

> +  
+    .. code-block:: bash
+
+        cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+  `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+  
+  You can install Python 3 easily using homebrew
+  
+    .. code-block:: bash
+
+      brew install python
+  
+  A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup

I think we should just drop this line - it's more mystifying than useful...

> +  
+    .. code-block:: bash
+
+        cd /usr/ports/net/flent && make install
+
+- **macOS:**
+
+  `Homebrew <https://brew.sh/>`_ and Python 3 must be installed
+  
+  You can install Python 3 easily using homebrew
+  
+    .. code-block:: bash
+
+      brew install python
+  
+  A more preferred way to install Python on macOS is to use `pyenv <https://github.com/pyenv/pyenv>`_, but this requires a bit more work to setup

As above

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/208#pullrequestreview-421395202

[-- Attachment #1.2: Type: text/html, Size: 2566 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org