Flent-users discussion archives
 help / color / mirror / Atom feed
* Re: [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205)
       [not found] <tohojo/flent/pull/205@github.com>
@ 2020-05-10 11:55 ` Toke Høiland-Jørgensen
  2020-05-11 10:02 ` Toke Høiland-Jørgensen
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-10 11:55 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 516 bytes --]

Hmm, the tests fail because this new plot type doesn't have any output when plotted from the existing data files in unittests/test_data.

To fix this, could you please:
- Add the new plot name to PLOTS_MAY_FAIL in unittests/test_plotters.py
- Add a new data file in unittests/test_data with one of your data files using this plot?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/205#issuecomment-626316607

[-- Attachment #1.2: Type: text/html, Size: 1458 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205)
       [not found] <tohojo/flent/pull/205@github.com>
  2020-05-10 11:55 ` [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205) Toke Høiland-Jørgensen
@ 2020-05-11 10:02 ` Toke Høiland-Jørgensen
  2020-05-11 16:26 ` Toke Høiland-Jørgensen
  2020-05-11 16:29 ` Toke Høiland-Jørgensen
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-11 10:02 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 449 bytes --]

Nah, it tries to plot all the plots with all the test data files. Probably ought to make it a bit smarter, but for now could you please just add all the new plot names to PLOTS_MAY_FAIL? And also add s-o-b tags to the two last commits (or just squash everything)?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/205#issuecomment-626603937

[-- Attachment #1.2: Type: text/html, Size: 1360 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205)
       [not found] <tohojo/flent/pull/205@github.com>
  2020-05-10 11:55 ` [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205) Toke Høiland-Jørgensen
  2020-05-11 10:02 ` Toke Høiland-Jørgensen
@ 2020-05-11 16:26 ` Toke Høiland-Jørgensen
  2020-05-11 16:29 ` Toke Høiland-Jørgensen
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-11 16:26 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 255 bytes --]

@tohojo approved this pull request.

Looks like it -thanks! :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/205#pullrequestreview-409332364

[-- Attachment #1.2: Type: text/html, Size: 1196 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205)
       [not found] <tohojo/flent/pull/205@github.com>
                   ` (2 preceding siblings ...)
  2020-05-11 16:26 ` Toke Høiland-Jørgensen
@ 2020-05-11 16:29 ` Toke Høiland-Jørgensen
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-11 16:29 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]

Merged #205 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/205#event-3323774206

[-- Attachment #1.2: Type: text/html, Size: 1449 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-11 16:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tohojo/flent/pull/205@github.com>
2020-05-10 11:55 ` [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205) Toke Høiland-Jørgensen
2020-05-11 10:02 ` Toke Høiland-Jørgensen
2020-05-11 16:26 ` Toke Høiland-Jørgensen
2020-05-11 16:29 ` Toke Høiland-Jørgensen

Flent-users discussion archives

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.flent.org/flent-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 flent-users flent-users/ https://lists.flent.org/flent-users \
		flent-users@flent.org
	public-inbox-index flent-users

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git