Flent-users discussion archives
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205)
Date: Sun, 10 May 2020 04:55:37 -0700	[thread overview]
Message-ID: <tohojo/flent/pull/205/c626316607@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/205@github.com>

[-- Attachment #1.1: Type: text/plain, Size: 516 bytes --]

Hmm, the tests fail because this new plot type doesn't have any output when plotted from the existing data files in unittests/test_data.

To fix this, could you please:
- Add the new plot name to PLOTS_MAY_FAIL in unittests/test_plotters.py
- Add a new data file in unittests/test_data with one of your data files using this plot?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:

[-- Attachment #1.2: Type: text/html, Size: 1458 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

Flent-users mailing list

       reply	other threads:[~2020-05-10 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tohojo/flent/pull/205@github.com>
2020-05-10 11:55 ` Toke Høiland-Jørgensen [this message]
2020-05-11 10:02 ` Toke Høiland-Jørgensen
2020-05-11 16:26 ` Toke Høiland-Jørgensen
2020-05-11 16:29 ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tohojo/flent/pull/205/c626316607@github.com \
    --to=notifications@github.com \
    --cc=flent@noreply.github.com \
    --cc=subscribed@noreply.github.com \
    --subject='Re: [Flent-users] [tohojo/flent] Add TCP delivery rate plots to rrul_be (#205)' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox