Flent-users discussion archives
 help / color / mirror / Atom feed
* [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125)
@ 2017-12-12 20:14 Pete Heist
  2017-12-12 20:23 ` Toke Høiland-Jørgensen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Pete Heist @ 2017-12-12 20:14 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 776 bytes --]

For some reason, the Go pflag packages (both of them) require long form flags with values to have equals signs. This works for me, but I'm not sure of and didn't test the local_bind stuff in particular, so by all means fix or replace any of it if there's a better way. :)
You can view, comment on, or merge this pull request online at:

  https://github.com/tohojo/flent/pull/125

-- Commit Summary --

  * Use = with all long form flags with values.

-- File Changes --

    M flent/runners.py (16)

-- Patch Links --

https://github.com/tohojo/flent/pull/125.patch
https://github.com/tohojo/flent/pull/125.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/125

[-- Attachment #1.2: Type: text/html, Size: 2686 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125)
  2017-12-12 20:14 [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125) Pete Heist
@ 2017-12-12 20:23 ` Toke Høiland-Jørgensen
  2017-12-14 11:10 ` Toke Høiland-Jørgensen
  2017-12-14 11:10 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-12-12 20:23 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 400 bytes --]

Ah right, forgot about that. Only comment on this is that the single-element extend calls should be changed to append without the wrapping in a list.

Also, please add a signed-off-by line to the commit message :)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/125#issuecomment-351182650

[-- Attachment #1.2: Type: text/html, Size: 2155 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125)
  2017-12-12 20:14 [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125) Pete Heist
  2017-12-12 20:23 ` Toke Høiland-Jørgensen
  2017-12-14 11:10 ` Toke Høiland-Jørgensen
@ 2017-12-14 11:10 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-12-14 11:10 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 192 bytes --]

Closed #125.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/125#event-1387464017

[-- Attachment #1.2: Type: text/html, Size: 1966 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125)
  2017-12-12 20:14 [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125) Pete Heist
  2017-12-12 20:23 ` Toke Høiland-Jørgensen
@ 2017-12-14 11:10 ` Toke Høiland-Jørgensen
  2017-12-14 11:10 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-12-14 11:10 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 234 bytes --]

Just fixed this manually and merged to master...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/125#issuecomment-351680990

[-- Attachment #1.2: Type: text/html, Size: 1815 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-12-14 11:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 20:14 [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125) Pete Heist
2017-12-12 20:23 ` Toke Høiland-Jørgensen
2017-12-14 11:10 ` Toke Høiland-Jørgensen
2017-12-14 11:10 ` Toke Høiland-Jørgensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox