Flent-users discussion archives
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] Use = with all long form flags with values. (#125)
Date: Tue, 12 Dec 2017 20:23:07 +0000 (UTC)	[thread overview]
Message-ID: <tohojo/flent/pull/125/c351182650@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/125@github.com>

[-- Attachment #1.1: Type: text/plain, Size: 400 bytes --]

Ah right, forgot about that. Only comment on this is that the single-element extend calls should be changed to append without the wrapping in a list.

Also, please add a signed-off-by line to the commit message :)

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:

[-- Attachment #1.2: Type: text/html, Size: 2155 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

Flent-users mailing list

  reply	other threads:[~2017-12-12 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 20:14 Pete Heist
2017-12-12 20:23 ` Toke Høiland-Jørgensen [this message]
2017-12-14 11:10 ` Toke Høiland-Jørgensen
2017-12-14 11:10 ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tohojo/flent/pull/125/c351182650@github.com \
    --to=notifications@github.com \
    --cc=flent@noreply.github.com \
    --cc=reply+01ead4bf19e457573976bdd207b4c2e4f06d45b2d2ad102792cf000000011647fcaa92a169ce10c7b0fd@reply.github.com \
    --cc=subscribed@noreply.github.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox