Flent-users discussion archives
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Comment <comment@noreply.github.com>,
	flent-users <flent-users@flent.org>
Subject: Re: [Flent-users] [tohojo/flent] Customized test displaying error (#203)
Date: Tue, 28 Apr 2020 13:51:18 -0700	[thread overview]
Message-ID: <tohojo/flent/issues/203/620847692@github.com> (raw)
In-Reply-To: <tohojo/flent/issues/203@github.com>


[-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --]

olg33 <notifications@github.com> writes:

>> Ohh, right, the markings_map is only used for irtt and iperf, for
> netperf the values are just passed directly through. Totally forgot
> about that. I guess I could fix that, but TBH I'm not terribly keen on
> supporting non-standard diffserv markings in this way.
>
>
> You are totally right, I'm not expecting you to do my job, that's
> unfair and you have been very generous already. I'm just looking for
> clues (like the one provided) to fix my setup.
>
>> Just checking, but when you say "someone else" you mean someone else who
> has access to that same system, right?
>
> Correct. Some Jr. members of my engineering team are only familiar
> with decimal values, no hex, so I want to help them out on that.

Hmm, I can kinda see how that might be useful in other scenarios. I
obviously can't put your particular custom values in, but maybe having
the ability to provide symbolic names for diffserv mappings would be
useful in a generalised form.

Say, a separate option like '--define-marking-name foo=0x28' which
would dynamically update the MARKINGS_MAP and make --test-parameter
markings=foo work. Then you could add your custom mappings to .flentrc
so they would not have to be specified on the command line on every run.

Would that work for you?


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/203#issuecomment-620847692

[-- Attachment #1.2: Type: text/html, Size: 2578 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

  parent reply	other threads:[~2020-04-28 20:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tohojo/flent/issues/203@github.com>
2020-03-24 17:42 ` Toke Høiland-Jørgensen
2020-03-26 14:54 ` Toke Høiland-Jørgensen
2020-03-26 17:59 ` Toke Høiland-Jørgensen
2020-03-31 14:15 ` Toke Høiland-Jørgensen
2020-04-01 10:09 ` Toke Høiland-Jørgensen
2020-04-01 10:33   ` Sebastian Moeller
2020-04-01 11:10 ` Toke Høiland-Jørgensen
2020-04-03  8:30 ` Toke Høiland-Jørgensen
     [not found] ` <tohojo/flent/issues/203/608963421@github.com>
2020-04-04  3:25   ` Dave Taht
2020-04-06  9:22 ` Toke Høiland-Jørgensen
2020-04-08 21:31 ` Toke Høiland-Jørgensen
2020-04-28  9:38 ` Toke Høiland-Jørgensen
     [not found] ` <tohojo/flent/issues/203/620745795@github.com>
2020-04-28 17:28   ` Dave Taht
     [not found] ` <tohojo/flent/issues/203/620754293@github.com>
2020-04-28 17:50   ` Dave Taht
2020-04-28 18:00 ` Toke Høiland-Jørgensen
2020-04-28 19:10 ` Toke Høiland-Jørgensen
     [not found] ` <tohojo/flent/issues/203/620824256@github.com>
2020-04-28 20:16   ` Dave Taht
2020-04-28 20:51 ` Toke Høiland-Jørgensen [this message]
2020-04-29 13:07 ` Toke Høiland-Jørgensen
2020-04-29 17:14 ` Toke Høiland-Jørgensen
2020-04-30 16:01 ` Toke Høiland-Jørgensen
2020-04-30 16:01 ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tohojo/flent/issues/203/620847692@github.com \
    --to=notifications@github.com \
    --cc=comment@noreply.github.com \
    --cc=flent-users@flent.org \
    --cc=flent@noreply.github.com \
    --cc=reply+AHVNJP72DDEV3OPSXZFQF6F4WR4ENEVBNHHCF7XB3M@reply.github.com \
    --subject='Re: [Flent-users] [tohojo/flent] Customized test displaying error (#203)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox