From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.4 Received: from mail.toke.dk by mail.toke.dk with LMTP id sUYbB3uXqF4xAAYAOr1fkg (envelope-from ) for ; Tue, 28 Apr 2020 22:52:11 +0200 Authentication-Results: mail.toke.dk; none (SPF check N/A for local connections - client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=FlWAwaHL Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id 02344731230 for ; Tue, 28 Apr 2020 22:52:09 +0200 (CEST) Received: from [::1] (port=56364 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.93) (envelope-from ) id 1jTXD5-007p2u-AX; Tue, 28 Apr 2020 23:52:07 +0300 Received: from out-27.smtp.github.com ([192.30.252.210]:44429) by web6.sd.eurovps.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jTXCx-007otl-Ij for flent-users@flent.org; Tue, 28 Apr 2020 23:52:04 +0300 Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id 99A36E0A07 for ; Tue, 28 Apr 2020 13:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588107078; bh=AMWBqM+2xWdbbU31GM5ePe7zjHeXgJrmUPHGeK/hB3o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FlWAwaHL7OKTDlNZTdcTwPCb15dmUoBzHfMVhfMLvuF7qzkww26zbShAA+wtPvLz/ oTO2caotQ2WsTeSuPFq3LrKdKhdDycDasoRUcs0/2RnJJPmHJNrFTQGQTckuqdTs1R GpfA9dBHDvNKc4dZj95Ev3Yc6O7+0N1yKcQ6I8fU= Date: Tue, 28 Apr 2020 13:51:18 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: comment X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: Re: [Flent-users] [tohojo/flent] Customized test displaying error (#203) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.29 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Comment , flent-users Content-Type: multipart/mixed; boundary="===============8397289485120509983==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============8397289485120509983== Content-Type: multipart/alternative; boundary="--==_mimepart_5ea897468a35c_16cf3ff1142cd9641707fd"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5ea897468a35c_16cf3ff1142cd9641707fd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit olg33 writes: >> Ohh, right, the markings_map is only used for irtt and iperf, for > netperf the values are just passed directly through. Totally forgot > about that. I guess I could fix that, but TBH I'm not terribly keen on > supporting non-standard diffserv markings in this way. > > > You are totally right, I'm not expecting you to do my job, that's > unfair and you have been very generous already. I'm just looking for > clues (like the one provided) to fix my setup. > >> Just checking, but when you say "someone else" you mean someone else who > has access to that same system, right? > > Correct. Some Jr. members of my engineering team are only familiar > with decimal values, no hex, so I want to help them out on that. Hmm, I can kinda see how that might be useful in other scenarios. I obviously can't put your particular custom values in, but maybe having the ability to provide symbolic names for diffserv mappings would be useful in a generalised form. Say, a separate option like '--define-marking-name foo=0x28' which would dynamically update the MARKINGS_MAP and make --test-parameter markings=foo work. Then you could add your custom mappings to .flentrc so they would not have to be specified on the command line on every run. Would that work for you? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/issues/203#issuecomment-620847692 ----==_mimepart_5ea897468a35c_16cf3ff1142cd9641707fd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

olg33 <notifications@github.com> writes:

>> Ohh, right, the markings_map is only used for irtt and iperf, for
> netperf the values are just passed directly through. Totally forgot
> about that. I guess I could fix that, but TBH I'm not terribly keen on
> supporting non-standard diffserv markings in this way.
>
>
> You are totally right, I'm not expecting you to do my job, that's
> unfair and you have been very generous already. I'm just looking for
> clues (like the one provided) to fix my setup.
>
>> Just checking, but when you say "someone else" you mean someone else who
> has access to that same system, right?
>
> Correct. Some Jr. members of my engineering team are only familiar
> with decimal values, no hex, so I want to help them out on that.

Hmm, I can kinda see how that might be useful in other scenarios. I
obviously can't put your particular custom values in, but maybe having
the ability to provide symbolic names for diffserv mappings would be
useful in a generalised form.

Say, a separate option like '--define-marking-name foo=0x28' which
would dynamically update the MARKINGS_MAP and make --test-parameter
markings=foo work. Then you could add your custom mappings to .flentrc
so they would not have to be specified on the command line on every run.

Would that work for you?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5ea897468a35c_16cf3ff1142cd9641707fd-- --===============8397289485120509983== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============8397289485120509983==--