olg33 <notifications@github.com> writes:

>> Ohh, right, the markings_map is only used for irtt and iperf, for
> netperf the values are just passed directly through. Totally forgot
> about that. I guess I could fix that, but TBH I'm not terribly keen on
> supporting non-standard diffserv markings in this way.
>
>
> You are totally right, I'm not expecting you to do my job, that's
> unfair and you have been very generous already. I'm just looking for
> clues (like the one provided) to fix my setup.
>
>> Just checking, but when you say "someone else" you mean someone else who
> has access to that same system, right?
>
> Correct. Some Jr. members of my engineering team are only familiar
> with decimal values, no hex, so I want to help them out on that.

Hmm, I can kinda see how that might be useful in other scenarios. I
obviously can't put your particular custom values in, but maybe having
the ability to provide symbolic names for diffserv mappings would be
useful in a generalised form.

Say, a separate option like '--define-marking-name foo=0x28' which
would dynamically update the MARKINGS_MAP and make --test-parameter
markings=foo work. Then you could add your custom mappings to .flentrc
so they would not have to be specified on the command line on every run.

Would that work for you?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.