Re: [Flent-users] [tohojo/flent] tc_iterate.c is borken for newer tcs (#146)

Re: [Flent-users] [tohojo/flent] tc_iterate.c is borken for newer tcs (#146)

[Dave Täht]

[-- Attachment #1.1: Type: text/plain, Size: 512 bytes --]

A) we add polling to tc. David liked this, Stephen didn't. I LOVE this.
B) find a way around iproute2 commit e209d4c83dc87470f259122be19afe4401407a06 - which does lookahead to see if the next command can be batched.

It's sad that it's just this past month when I had a major need that this broke. I'll find a way to fix it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/146#issuecomment-414092085

[-- Attachment #1.2: Type: text/html, Size: 3890 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

Re: [Flent-users] [tohojo/flent] tc_iterate.c is borken for newer tcs (#146)

[Toke Høiland-Jørgensen]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]

So, finally got around to look at this. Wow, that's an annoying change for the Flent use case. Did you find a workaround?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/146#issuecomment-452267712

[-- Attachment #1.2: Type: text/html, Size: 1974 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

Re: [Flent-users] [tohojo/flent] tc_iterate.c is borken for newer tcs (#146)

[Toke Høiland-Jørgensen]

[-- Attachment #1.1: Type: text/plain, Size: 857 bytes --]

flent-users <notifications@github.com> writes:

> On Tue, Jan 8, 2019 at 3:34 AM Toke Høiland-Jørgensen <
> notifications@github.com> wrote:
>
>> So, finally got around to look at this. Wow, that's an annoying change for
>> the Flent use case. Did you find a workaround?
>>
>
> Other than ripping out the relevant commit or writing the netlnk code from
> scratch? No. It's a pretty crippling change. Lemmee forward where the convo
> stalled out.

Right. I guess I'll go write a monitor mode for iproute2 and see if
it'll be accepted upstream...

But yeah, Steven's suggestion about just adding a flag was also my first
thought...

-Toke


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/146#issuecomment-452331033

[-- Attachment #1.2: Type: text/html, Size: 3321 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

Re: [Flent-users] [tohojo/flent] tc_iterate.c is borken for newer tcs (#146)

[Dave Täht]

[-- Attachment #1.1: Type: text/plain, Size: 1498 bytes --]

Toke Høiland-Jørgensen <notifications@github.com> writes:

> flent-users <notifications@github.com> writes:
>
>> On Tue, Jan 8, 2019 at 3:34 AM Toke Høiland-Jørgensen <
>> notifications@github.com> wrote:
>>
>>> So, finally got around to look at this. Wow, that's an annoying
> change for
>>> the Flent use case. Did you find a workaround?
>>>
>>
>> Other than ripping out the relevant commit or writing the netlnk
> code from
>> scratch? No. It's a pretty crippling change. Lemmee forward where
> the convo
>> stalled out.
>
> Right. I guess I'll go write a monitor mode for iproute2 and see if
> it'll be accepted upstream...
>
> But yeah, Steven's suggestion about just adding a flag was also my
> first
> thought...

It would be nice for this facility to work again. I have not been doing
any kernel-related work for a while, but will gladly test, as usual, if
you come up with something. I happen to prefer the idea of the generic
monitoring mode with high resolution timing support. Alternatively
updating the common "watch" utilities to have better than 1sec
resolution would be good.

>
> -Toke
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/146#issuecomment-455785969

[-- Attachment #1.2: Type: text/html, Size: 4908 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org