Flent-users discussion archives
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [Flent-users] Re: [tohojo/flent] Runners: stop stats collection iterators after test-time is completed (#237)
Date: Wed, 13 Oct 2021 13:58:32 -0700	[thread overview]
Message-ID: <tohojo/flent/pull/237/review/779083332@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/237@github.com>

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

@tohojo commented on this pull request.

> @@ -41,7 +41,8 @@ then
 command_string=$(cat <<EOF
-for i in \$(seq $count); do
+endtime=\$(date -d "\$length sec" +%s%N);

Ah, yes, the sorry, the first `$` should be escaped, but not the second one. I.e., `$length` should be evaluated straight away...

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:

[-- Attachment #2: Type: text/html, Size: 1967 bytes --]

  parent reply	other threads:[~2021-10-13 20:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 19:10 [Flent-users] [tohojo/flent] Draft: " Shashank D
2021-10-13 13:27 ` [Flent-users] Re: [tohojo/flent] " Toke Høiland-Jørgensen
2021-10-13 18:12 ` Shashank D
2021-10-13 18:23 ` Shashank D
2021-10-13 20:58 ` Toke Høiland-Jørgensen [this message]
2021-10-14 13:34 ` Shashank D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tohojo/flent/pull/237/review/779083332@github.com \
    --to=notifications@github.com \
    --cc=flent@noreply.github.com \
    --cc=reply+AHVNJP5BYPJGFUI4PZSUI4N7OMUXREVBNHHDYDG56Q@reply.github.com \
    --cc=subscribed@noreply.github.com \
    --subject='[Flent-users] Re: [tohojo/flent] Runners: stop stats collection iterators after test-time is completed (#237)' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox