From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.github.com (out-21.smtp.github.com [192.30.252.204])
	by mail.toke.dk (Postfix) with ESMTPS id 920478CFAFC
	for <flent-users@flent.org>; Wed, 13 Oct 2021 22:58:35 +0200 (CEST)
Authentication-Results: mail.toke.dk;
	dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=QBVzFLM8
Received: from github-lowworker-bc343b9.ash1-iad.github.net (github-lowworker-bc343b9.ash1-iad.github.net [10.56.122.73])
	by smtp.github.com (Postfix) with ESMTP id 1E062520E98
	for <flent-users@flent.org>; Wed, 13 Oct 2021 13:58:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
	s=pf2014; t=1634158712;
	bh=VEl4xMX6a4SaqSuBiYcqIyyMAWhaf+krAkHHs4/fBH8=;
	h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
	 List-Archive:List-Post:List-Unsubscribe:From;
	b=QBVzFLM8axUtJ2cfB1X3OLdVle+CjvO9Qt160vyQg6eGFWyrbifH5s+5SeYARUPs/
	 s4u39R8hYL66FbotnMILnszkXR20KUCYXlpC3YJB+UGi+7mc4UCqy6NDOF2QNRn+LQ
	 Fn6hLOKNzToPycdhPK5rqVD+lgRpcQWPIp19zEB4=
Date: Wed, 13 Oct 2021 13:58:32 -0700
From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Message-ID: <tohojo/flent/pull/237/review/779083332@github.com>
In-Reply-To: <tohojo/flent/pull/237@github.com>
References: <tohojo/flent/pull/237@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_61674878f9c1_58f5c710726e5";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: tohojo
X-GitHub-Recipient: flent-users
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: flent-users@flent.org
Message-ID-Hash: OVDJ4QNHZQAS2GPF5OSLJG3SIM54BHMO
X-Message-ID-Hash: OVDJ4QNHZQAS2GPF5OSLJG3SIM54BHMO
X-MailFrom: noreply@github.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: Subscribed <subscribed@noreply.github.com>
X-Mailman-Version: 3.3.4
Reply-To: tohojo/flent <reply+AHVNJP5BYPJGFUI4PZSUI4N7OMUXREVBNHHDYDG56Q@reply.github.com>
Subject: [Flent-users] Re: [tohojo/flent] Runners: stop stats collection iterators after test-time is completed (#237)
List-Id: Flent discussion list <flent-users.flent.org>
Archived-At: <https://lists.flent.org/flent-users/tohojo/flent/pull/237/review/779083332@github.com/>
List-Archive: <https://lists.flent.org/flent-users/>
List-Help: <mailto:flent-users-request@flent.org?subject=help>
List-Owner: <mailto:flent-users-owner@flent.org>
List-Post: <mailto:flent-users@flent.org>
List-Subscribe: <mailto:flent-users-join@flent.org>
List-Unsubscribe: <mailto:flent-users-leave@flent.org>


----==_mimepart_61674878f9c1_58f5c710726e5
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@tohojo commented on this pull request.



> @@ -41,7 +41,8 @@ then
 fi
 
 command_string=$(cat <<EOF
-for i in \$(seq $count); do
+endtime=\$(date -d "\$length sec" +%s%N);

Ah, yes, the sorry, the first `$` should be escaped, but not the second one. I.e., `$length` should be evaluated straight away...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/237#discussion_r728442510
----==_mimepart_61674878f9c1_58f5c710726e5
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@tohojo</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/tohojo/flent/pull/237#discussion_r728442510">flent/scripts/ss_iterate.sh</a>:</p>
<pre style='color:#555'>&gt; @@ -41,7 +41,8 @@ then
 fi
 
 command_string=$(cat &lt;&lt;EOF
-for i in \$(seq $count); do
+endtime=\$(date -d &quot;\$length sec&quot; +%s%N);
</pre>
<p>Ah, yes, the sorry, the first <code>$</code> should be escaped, but not the second one. I.e., <code>$length</code> should be evaluated straight away...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/tohojo/flent/pull/237#discussion_r728442510">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AHVNJP7MBWSFL4WFCMSLNYTUGXXHRANCNFSM5EZCV33A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&amp;mt=8&amp;pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&amp;referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AHVNJPZEYNNAUOWA2APW6M3UGXXHRA5CNFSM5EZCV33KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFZX54RA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/tohojo/flent/pull/237#discussion_r728442510",
"url": "https://github.com/tohojo/flent/pull/237#discussion_r728442510",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_61674878f9c1_58f5c710726e5--