From: Pete Heist <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [Flent-users] [tohojo/flent] Add multiple inheritance support for batch files. (#175)
Date: Tue, 27 Aug 2019 11:34:04 -0700 [thread overview]
Message-ID: <tohojo/flent/pull/175@github.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1769 bytes --]
I don't know how interested you are in taking this, _but_, this allows sections to inherit from multiple other sections by specifying a comma separated value for inherits, for example:
```
[Batch::global]
abstract = yes
title = ${batch_title}
output_path = batch-${batch_time}-${batch_title}/${batch_name}
batch_title = flent-mi
filename_extra = extra
ip_version = 4
length = 10
hosts = apu2c
[Batch::debug]
abstract = yes
extended_metadata = yes
debug_error = yes
debug_log = yes
[Batch::tcp-upload]
inherits = global, debug
test_name = tcp_1up_noping
disabled = no
```
Batches later in the comma separated list take precedence.
This is a simple example, but I've found that it helps me clean up a batch file where I have several batch sections that share a common configuration, but that can also benefit from importing settings specific to the test being run that is not specific to the configuration. I guess it could help any time settings are needed from more than one inheritance hierarchy.
I haven't explored the various ways that people could shoot themselves in the foot with this, but then again, they don't have to use it, and things should work the same as they do today. :)
Signed-off-by: Pete Heist <pete@heistp.net>
You can view, comment on, or merge this pull request online at:
https://github.com/tohojo/flent/pull/175
-- Commit Summary --
* Add multiple inheritance support for batch files.
-- File Changes --
M flent/batch.py (11)
-- Patch Links --
https://github.com/tohojo/flent/pull/175.patch
https://github.com/tohojo/flent/pull/175.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/175
[-- Attachment #1.2: Type: text/html, Size: 3498 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
next reply other threads:[~2019-08-27 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 18:34 Pete Heist [this message]
2019-08-28 9:53 ` Toke Høiland-Jørgensen
2019-08-28 10:19 ` Pete Heist
2019-08-29 14:02 ` Toke Høiland-Jørgensen
2019-08-29 14:04 ` Toke Høiland-Jørgensen
2019-08-29 14:04 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tohojo/flent/pull/175@github.com \
--to=notifications@github.com \
--cc=flent@noreply.github.com \
--cc=reply+AHVNJP6Q5E47ZLDHEVPMJE53OK4CZEVBNHHBZ52FPA@reply.github.com \
--cc=subscribed@noreply.github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox