From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from mail.toke.dk by mail.toke.dk with LMTP id Yz7EJNV3ZV0WCwAAOr1fkg (envelope-from ) for ; Tue, 27 Aug 2019 20:35:01 +0200 Authentication-Results: mail.toke.dk; none (SPF check N/A for local connections - client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=SX3H2FIH Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id 649D865986C for ; Tue, 27 Aug 2019 20:34:58 +0200 (CEST) Received: from [::1] (port=56050 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.92) (envelope-from ) id 1i2gIz-00FEeh-RX; Tue, 27 Aug 2019 21:34:57 +0300 Received: from out-3.smtp.github.com ([192.30.252.194]:51875) by web6.sd.eurovps.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i2gIo-00FEXv-PY for flent-users@flent.org; Tue, 27 Aug 2019 21:34:53 +0300 Date: Tue, 27 Aug 2019 11:34:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566930844; bh=UsDqxPhl1kPa8ZoaiVj+03e9uESnKseQ5Dsmu9tua9M=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=SX3H2FIHemYBeyCcy2jusfSRbthvR4XFeApeD5sIDnqDTN5ZeI3n4cd/sXCRfaKqT JPOeSg7Ua116+KTqZxCmjhnzhqTcILS7YeGJmWG7yqgXNwYk5E16qBm+5EF0G8bl5V lj2nq/fjJTvkUhdGpJJjinLKR4x2eEBDScN677ow= From: Pete Heist To: tohojo/flent Message-ID: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: [Flent-users] [tohojo/flent] Add multiple inheritance support for batch files. (#175) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.27 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Subscribed Content-Type: multipart/mixed; boundary="===============1937776447411577405==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============1937776447411577405== Content-Type: multipart/alternative; boundary="--==_mimepart_5d65779cd3e81_12263fcc78ccd95c77211"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5d65779cd3e81_12263fcc78ccd95c77211 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit I don't know how interested you are in taking this, _but_, this allows sections to inherit from multiple other sections by specifying a comma separated value for inherits, for example: ``` [Batch::global] abstract = yes title = ${batch_title} output_path = batch-${batch_time}-${batch_title}/${batch_name} batch_title = flent-mi filename_extra = extra ip_version = 4 length = 10 hosts = apu2c [Batch::debug] abstract = yes extended_metadata = yes debug_error = yes debug_log = yes [Batch::tcp-upload] inherits = global, debug test_name = tcp_1up_noping disabled = no ``` Batches later in the comma separated list take precedence. This is a simple example, but I've found that it helps me clean up a batch file where I have several batch sections that share a common configuration, but that can also benefit from importing settings specific to the test being run that is not specific to the configuration. I guess it could help any time settings are needed from more than one inheritance hierarchy. I haven't explored the various ways that people could shoot themselves in the foot with this, but then again, they don't have to use it, and things should work the same as they do today. :) Signed-off-by: Pete Heist <pete@heistp.net> You can view, comment on, or merge this pull request online at: https://github.com/tohojo/flent/pull/175 -- Commit Summary -- * Add multiple inheritance support for batch files. -- File Changes -- M flent/batch.py (11) -- Patch Links -- https://github.com/tohojo/flent/pull/175.patch https://github.com/tohojo/flent/pull/175.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/175 ----==_mimepart_5d65779cd3e81_12263fcc78ccd95c77211 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

I don't know how interested you are in taking this, but, this allows sections to inherit from multiple other sections by specifying a comma separated value for inherits, for example:

[Batch::global]
abstract = yes
title = ${batch_title}
output_path = batch-${batch_time}-${batch_title}/${batch_name}
batch_title = flent-mi
filename_extra = extra
ip_version = 4
length = 10
hosts = apu2c

[Batch::debug]
abstract = yes
extended_metadata = yes
debug_error = yes
debug_log = yes

[Batch::tcp-upload]
inherits = global, debug
test_name = tcp_1up_noping
disabled = no

Batches later in the comma separated list take precedence.

This is a simple example, but I've found that it helps me clean up a batch file where I have several batch sections that share a common configuration, but that can also benefit from importing settings specific to the test being run that is not specific to the configuration. I guess it could help any time settings are needed from more than one inheritance hierarchy.

I haven't explored the various ways that people could shoot themselves in the foot with this, but then again, they don't have to use it, and things should work the same as they do today. :)

Signed-off-by: Pete Heist pete@heistp.net

You can view, comment on, or merge this pull request online at:

  https://github.com/tohojo/flent/pull/175

Commit Summary

  • Add multiple inheritance support for batch files.

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5d65779cd3e81_12263fcc78ccd95c77211-- --===============1937776447411577405== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============1937776447411577405==--