Flent-users discussion archives
 help / color / mirror / Atom feed
* Re: [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207)
       [not found] <tohojo/flent/issues/207@github.com>
@ 2020-05-26  7:05 ` Toke Høiland-Jørgensen
  2020-05-26  9:36 ` Toke Høiland-Jørgensen
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-26  7:05 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 1231 bytes --]



On 26 May 2020 08:37:39 CEST, Kris Anderson <notifications@github.com> wrote:
>I have to start by saying this isn't your problem. But I'm also not
>sure on the status of this and from what I can tell you're the last
>person I can see that said anything about reaching out to the Netperf
>devs to enable this flag:
>
>https://github.com/Homebrew/homebrew-core/pull/25503
>
>Did you ever hear back from them?

No luck with upstream, unfortunately. Others have also noticed this in 2.7.0: https://github.com/HewlettPackard/netperf/issues/35

>  If not, is there anything I can do to
>help make this easier for macOS users?
>
>The Homebrew dev did mention in your PR that we could create a tap for
>this. Is that something you would want to maintain?

I don't own any OSX devices, so don't really think it makes sense for me to maintain that...

> Would you like me
>to create a tap under my account and create a PR to update your README
>file to help macOS users get Flent up and running?

Now this sounds like a better idea :) sure, go ahead!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/207#issuecomment-633847922

[-- Attachment #1.2: Type: text/html, Size: 2307 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207)
       [not found] <tohojo/flent/issues/207@github.com>
  2020-05-26  7:05 ` [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207) Toke Høiland-Jørgensen
@ 2020-05-26  9:36 ` Toke Høiland-Jørgensen
  2020-05-27  9:10 ` Toke Høiland-Jørgensen
  2020-06-01 10:28 ` Toke Høiland-Jørgensen
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-26  9:36 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]

Kris Anderson <notifications@github.com> writes:

> Sounds good!
>
> I put together a working [brew
> tap](https://github.com/kris-anderson/homebrew-netperf) that should
> solve this for others. I'll take a look at creating a PR for you in
> the next couple of days to update the README and hopefully make
> running Flent easy for all macOS users using Homebrew.
>
> I tried to keep my tap true to the original formulae, so it still
> downloads the same original file from HP, but it does a find and
> replace during install to patch the file and then it adds the flag
> `--demo-mode` when compiling.

LGTM, thanks!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/207#issuecomment-633919413

[-- Attachment #1.2: Type: text/html, Size: 1808 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207)
       [not found] <tohojo/flent/issues/207@github.com>
  2020-05-26  7:05 ` [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207) Toke Høiland-Jørgensen
  2020-05-26  9:36 ` Toke Høiland-Jørgensen
@ 2020-05-27  9:10 ` Toke Høiland-Jørgensen
  2020-06-01 10:28 ` Toke Høiland-Jørgensen
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-05-27  9:10 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 1257 bytes --]

Kris Anderson <notifications@github.com> writes:

> I want to think about the naming a bit more before I create a PR
> (undecided on `netperf-demo-mode` or if that should be something else
> like `netperf-enable-demo` or something). Do you have an opinion on
> the package name? Homebrew will use `netperf` by default, but they
> recommend using a new name to keep the installs a little simpler for
> end users.

Yeah, naming is the hardest part :)
I'm no better at it myself, so don't really have any opinion. Other than
the fact that I don't like the 'demo mode' feature name in the first
place - it has the wrong connotations, I think ("demo" sounds a bit too
much like "beta", or something unfinished).

> I also refactored the readme a bit. Not sure if you're a fan of this look, but wanted to get your thoughts before I submit a PR. Here's my branch with the README changes this far:
> https://github.com/kris-anderson/flent/tree/update-readme-for-macos

I think it's better to move 'other linux' up with debian/ubuntu/Arch,
but other than that, no objections :)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/207#issuecomment-634532933

[-- Attachment #1.2: Type: text/html, Size: 2321 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207)
       [not found] <tohojo/flent/issues/207@github.com>
                   ` (2 preceding siblings ...)
  2020-05-27  9:10 ` Toke Høiland-Jørgensen
@ 2020-06-01 10:28 ` Toke Høiland-Jørgensen
  3 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-06-01 10:28 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 194 bytes --]

Closed #207.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/207#event-3392511353

[-- Attachment #1.2: Type: text/html, Size: 1426 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-01 10:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tohojo/flent/issues/207@github.com>
2020-05-26  7:05 ` [Flent-users] [tohojo/flent] Status of "--enabled-demo" mode for macOS Homebrew installs of Netperf (#207) Toke Høiland-Jørgensen
2020-05-26  9:36 ` Toke Høiland-Jørgensen
2020-05-27  9:10 ` Toke Høiland-Jørgensen
2020-06-01 10:28 ` Toke Høiland-Jørgensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox