* [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179)
@ 2019-09-06 13:23 Pete Heist
2019-09-06 14:50 ` Dave Täht
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Pete Heist @ 2019-09-06 13:23 UTC (permalink / raw)
To: tohojo/flent; +Cc: Subscribed
[-- Attachment #1.1: Type: text/plain, Size: 1049 bytes --]
Currently, the output filenames for batches always include `batch_time`:
```
def gen_filename(self, settings, batch, argset, rep):
filename = "batch-%s-%s-%s" % (
settings.BATCH_NAME,
batch['batch_time'],
batch.get('filename_extra', "%s-%s" % (argset, rep))
)
return clean_path(filename)
```
On one hand, this ensures that output filenames are unique, but on the other hand, one can't create stable links to the output filenames that don't change between runs, for example in a static HTML or markdown file.
What I could do is add a `filename_no_time` or similar parameter that if set to anything "truthy" (maybe if s in [ '1', 'true', 'yes' ]), excludes the time from the filename, then it's up to people to properly set `filename_extra`.
Would you be ok if I do that, or do you have any other suggestions for this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/179
[-- Attachment #1.2: Type: text/html, Size: 2390 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179)
2019-09-06 13:23 [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179) Pete Heist
@ 2019-09-06 14:50 ` Dave Täht
2019-09-06 15:36 ` Pete Heist
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dave Täht @ 2019-09-06 14:50 UTC (permalink / raw)
To: tohojo/flent; +Cc: Comment, flent-users
[-- Attachment #1.1: Type: text/plain, Size: 1357 bytes --]
Pete Heist <notifications@github.com> writes:\r
\r
> Currently, the output filenames for batches always include batch_time:\r
>\r
> def gen_filename(self, settings, batch, argset, rep):\r
> filename = "batch-%s-%s-%s" % (\r
> settings.BATCH_NAME,\r
> batch['batch_time'],\r
> batch.get('filename_extra', "%s-%s" % (argset, rep))\r
> )\r
> return clean_path(filename)\r
>\r
> On one hand, this ensures that output filenames are unique, but on the\r
> other hand, one can't create stable links to the output filenames that\r
> don't change between runs, for example in a static HTML or markdown\r
> file.\r
>\r
> What I could do is add a filename_no_time or similar parameter that if\r
> set to anything "truthy" (maybe if s in [ '1', 'true', 'yes' ]),\r
> excludes the time from the filename, then it's up to people to\r
> properly set filename_extra.\r
>\r
> Would you be ok if I do that, or do you have any other suggestions for\r
> this?\r
\r
--no-time\r
\r
>\r
> —\r
> You are receiving this because you are subscribed to this thread.\r
> Reply to this email directly, view it on GitHub, or mute the thread.\r
\r
\r
-- \r
You are receiving this because you commented.\r
Reply to this email directly or view it on GitHub:\r
https://github.com/tohojo/flent/issues/179#issuecomment-528885668
[-- Attachment #1.2: Type: text/html, Size: 3034 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179)
2019-09-06 13:23 [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179) Pete Heist
2019-09-06 14:50 ` Dave Täht
@ 2019-09-06 15:36 ` Pete Heist
2019-09-06 18:02 ` Toke Høiland-Jørgensen
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Pete Heist @ 2019-09-06 15:36 UTC (permalink / raw)
To: tohojo/flent; +Cc: Comment, flent-users
[-- Attachment #1.1: Type: text/plain, Size: 599 bytes --]
I'd prefer the `--no-time` flag fwiw, simpler and more visible.
Symlinks could help in some cases, but the challenges for me are:
- there'd need to be one per individual test run (i.e. many per batch)
- one needs to take care to maintain symlinks when doing scp, rsync, etc
- I have supporting files that share the same base name as the .flent.gz file which would also need to be symlinked, so it could get to be many symlinks :)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/179#issuecomment-528903825
[-- Attachment #1.2: Type: text/html, Size: 2011 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179)
2019-09-06 13:23 [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179) Pete Heist
2019-09-06 14:50 ` Dave Täht
2019-09-06 15:36 ` Pete Heist
@ 2019-09-06 18:02 ` Toke Høiland-Jørgensen
2019-09-09 5:56 ` Pete Heist
2019-09-09 5:56 ` Pete Heist
4 siblings, 0 replies; 6+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-09-06 18:02 UTC (permalink / raw)
To: tohojo/flent; +Cc: Comment, flent-users
[-- Attachment #1.1: Type: text/plain, Size: 307 bytes --]
> Would you be ok if I do that, or do you have any other suggestions for
> this?
Not opposed to having an option; --batch-no-timestamp ?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/179#issuecomment-528955351
[-- Attachment #1.2: Type: text/html, Size: 1690 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179)
2019-09-06 13:23 [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179) Pete Heist
` (2 preceding siblings ...)
2019-09-06 18:02 ` Toke Høiland-Jørgensen
@ 2019-09-09 5:56 ` Pete Heist
2019-09-09 5:56 ` Pete Heist
4 siblings, 0 replies; 6+ messages in thread
From: Pete Heist @ 2019-09-09 5:56 UTC (permalink / raw)
To: tohojo/flent; +Cc: Comment, flent-users
[-- Attachment #1.1: Type: text/plain, Size: 240 bytes --]
Added in 2d0d8fbd844b2f2153f098e157294983e3432dc7, thanks for accepting.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/179#issuecomment-529311035
[-- Attachment #1.2: Type: text/html, Size: 1834 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179)
2019-09-06 13:23 [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179) Pete Heist
` (3 preceding siblings ...)
2019-09-09 5:56 ` Pete Heist
@ 2019-09-09 5:56 ` Pete Heist
4 siblings, 0 replies; 6+ messages in thread
From: Pete Heist @ 2019-09-09 5:56 UTC (permalink / raw)
To: tohojo/flent; +Cc: Comment, flent-users
[-- Attachment #1.1: Type: text/plain, Size: 174 bytes --]
Closed #179.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/179#event-2617445990
[-- Attachment #1.2: Type: text/html, Size: 1929 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-09 5:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 13:23 [Flent-users] [tohojo/flent] Stable output filenames for batch runs (#179) Pete Heist
2019-09-06 14:50 ` Dave Täht
2019-09-06 15:36 ` Pete Heist
2019-09-06 18:02 ` Toke Høiland-Jørgensen
2019-09-09 5:56 ` Pete Heist
2019-09-09 5:56 ` Pete Heist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox