Re: [Flent-users] [tohojo/flent] packet loss stats (#106) - Toke Høiland-Jørgensen

From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] packet loss stats (#106)
Date: Sun, 15 Oct 2017 17:18:05 +0000 (UTC)	[thread overview]
Message-ID: <tohojo/flent/issues/106/336726462@github.com> (raw)
In-Reply-To: <tohojo/flent/issues/106@github.com>

[-- Attachment #1.1: Type: text/plain, Size: 1739 bytes --]

Pete Heist <notifications@github.com> writes:

> Thanks again both for your kind help and feedback on this. I hope it's
> useful, and if not, it sure was fun anyway!

Very nice, and definitely useful! :)

Took it for a quick spin on localhost, some oddities from my initial
fiddling:

- On first run I expected it to work similar to ping, i.e., output data
  points as packets come in. Instead I almost immediately get a summary.
  Ah, it's running for a single second, and needs -v to output
  per-packet datapoints. For one-off command-line use it might be more
  useful to default to a more ping-like output (i.e., run until killed,
  output data points)?

- Hmm, -d 10 doesn't work. Ah, -d 10s does. Maybe default to seconds if
  no unit is given?

- Let's look at the json output. Oops, -o stdout outputs garbage to the
  terminal; ah, it's gzipped and needs -nogzip. Probably better to
  default stdout to not being gzipped? And instead of adding an
  extension, do the opposite and detect whether or not to gzip from the
  supplied file name instead? If I do '-o test.json' I get
  'test.json.json.gz' which is confusing. Also, supplying a filename of
  '-' creates '-.json.gz' instead of outputting to stdout. And the
  output file is written even if I cancel with Ctrl+C.

I consider all these minor issues, though, and overall it looks good!
I'll see if I can find some time to add support to Flent and try it out
in my testbed in various scenarios. Not sure if I'll have time this
week, though, have another deadline to attend to...

-Toke

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/106#issuecomment-336726462

[-- Attachment #1.2: Type: text/html, Size: 5112 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org