From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) by mail.toke.dk (Postfix) with ESMTPS id 74BDB8D36DA for ; Tue, 19 Oct 2021 22:11:05 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=ZOAvk+mS Received: from github-lowworker-98efffe.ac4-iad.github.net (github-lowworker-98efffe.ac4-iad.github.net [10.52.122.80]) by smtp.github.com (Postfix) with ESMTP id BB9DC56056F for ; Tue, 19 Oct 2021 13:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634674264; bh=w6BrNoKn+OYruG55bbYG5qHngpWV7sXz264j9768XgY=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=ZOAvk+mScz+kLqujmmrfs9/zpm0VkZRcjfXOW6DD8HAsTx+5vj6vE3OvzkNkDxXYt mfvpk9oJKwas+GxjP0I/5Ady/ayeaXolfBg/HG6JWEzI1oZ1bjbFiekYhyceTgpouw 1t2QQWz4dvzmgkeeY8EKHGo1esyQG8/PuIIfW8d0= Date: Tue, 19 Oct 2021 13:11:04 -0700 From: Hrishikesh Athalye To: tohojo/flent Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_616f2658adcf7_7ed1c710866ec"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: hrishikeshathalye X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: IXRYNQY3B7PZKPLAFZQ3L6KMTYA6RDR7 X-Message-ID-Hash: IXRYNQY3B7PZKPLAFZQ3L6KMTYA6RDR7 X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_616f2658adcf7_7ed1c710866ec Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Added the --test-payload option for sending a custom payload by using netperf's buffer prefill option You can view, comment on, or merge this pull request online at: https://github.com/tohojo/flent/pull/243 -- Commit Summary -- * Added --test-payload option -- File Changes -- M flent/runners.py (9) M flent/settings.py (6) M flent/testenv.py (2) -- Patch Links -- https://github.com/tohojo/flent/pull/243.patch https://github.com/tohojo/flent/pull/243.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243 ----==_mimepart_616f2658adcf7_7ed1c710866ec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Added the --test-payload option for sending a custom payload by using netperf's buffer prefill option

You can view, comment on, or merge this pull request online at:

  https://github.com/tohojo/flent/pull/243

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_616f2658adcf7_7ed1c710866ec-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-18.smtp.github.com [192.30.252.201]) by mail.toke.dk (Postfix) with ESMTPS id 4D2E78D3872 for ; Wed, 20 Oct 2021 00:30:07 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=wAXQDvPd Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id D85E03408D0 for ; Tue, 19 Oct 2021 15:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634682605; bh=aAa1Wwgt3F50XsTzf0y5MwvdXu1sBS4Xjg4uFk0DUpE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wAXQDvPd2W0xw27KbnOTrRTpB1W1p4NQq1cgyU19nmwoPdg4eUSjEGwxxB7lHzi6b tji962d/WPYd5rwpGaZpUN04umMRV8Pt98+BtyJxf/3ccF++qnnhMvSjtXvIJ5u4vU r8GVOg4VuNWJ1X6Ty9gqZixaVxeiXpssOvdUijuY= Date: Tue, 19 Oct 2021 15:30:05 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_616f46edc9fdf_64d6c710710fc"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: G25GRCMBBCUBWE42XDH5QDGVD7K3CNHF X-Message-ID-Hash: G25GRCMBBCUBWE42XDH5QDGVD7K3CNHF X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_616f46edc9fdf_64d6c710710fc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @tohojo requested changes on this pull request. Please add a paragraph of text to the commit message describing why the feature is useful. A few nits on the code, but otherwise looks good! :) > # Sanity check; is /dev/urandom readable? If so, use it to # pre-fill netperf's buffers - self.run_simple(['dd', 'if=/dev/urandom', 'of=/dev/null', 'bs=1', 'count=1'], errmsg="Err") - netperf['buffer'] = '-F /dev/urandom' + fillFile = args['test_payload'] + self.run_simple(['dd', f'if={fillFile}', 'of=/dev/null', 'bs=1', 'count=1'], errmsg="Err") + netperf['buffer'] = f'-F {fillFile}' Flent runs on Python versions as old as 3.5, so we can't use f-strings, sadly... > @@ -1022,10 +1023,14 @@ def check(self): netperf['-e'] = True try: + # If --test-payload option is specified, use data from that file + # else use the default value /dev/urandom. + # Below sanity check will be performed in either case. I'm not sure if the sanity check makes sense for a user-specified file: it means we'll just silently ignore the option if the file is not readable. I think it's better to fail noisily. We could do this either by doing the check but erroring out if it fails (it's the default), or we could skip the test for custom values and just let netperf fail when it can't open it. > @@ -378,6 +378,12 @@ def __call__(self, parser, namespace, values, option_string=None): "to decrease the socket buffer size. Can be specified multiple times, " "with each value corresponding to a stream of a test.") +test_group.add_argument( + "--test-payload", + action="store", type=unicode, dest="TEST_PAYLOAD", default='/dev/urandom', + help="Path to file containing payload to pre-fill the netperf buffers with" Missing space at the end of the first string here > # Sanity check; is /dev/urandom readable? If so, use it to # pre-fill netperf's buffers - self.run_simple(['dd', 'if=/dev/urandom', 'of=/dev/null', 'bs=1', 'count=1'], errmsg="Err") - netperf['buffer'] = '-F /dev/urandom' + fillFile = args['test_payload'] Variables are generally lowercase and underscore-separated rather then camelCase... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#pullrequestreview-783839744 ----==_mimepart_616f46edc9fdf_64d6c710710fc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo requested changes on this pull request.

Please add a paragraph of text to the commit message describing why the feature is useful.

A few nits on the code, but otherwise looks good! :)

In flent/runners.py:

>                  # Sanity check; is /dev/urandom readable? If so, use it to
                 # pre-fill netperf's buffers
-                self.run_simple(['dd', 'if=/dev/urandom', 'of=/dev/null', 'bs=1', 'count=1'], errmsg="Err")
-                netperf['buffer'] = '-F /dev/urandom'
+                fillFile = args['test_payload']
+                self.run_simple(['dd', f'if={fillFile}', 'of=/dev/null', 'bs=1', 'count=1'], errmsg="Err")
+                netperf['buffer'] = f'-F {fillFile}'

Flent runs on Python versions as old as 3.5, so we can't use f-strings, sadly...

In flent/runners.py:

> @@ -1022,10 +1023,14 @@ def check(self):
                 netperf['-e'] = True
 
             try:
+                # If --test-payload option is specified, use data from that file
+                # else use the default value /dev/urandom. 
+                # Below sanity check will be performed in either case.

I'm not sure if the sanity check makes sense for a user-specified file: it means we'll just silently ignore the option if the file is not readable. I think it's better to fail noisily. We could do this either by doing the check but erroring out if it fails (it's the default), or we could skip the test for custom values and just let netperf fail when it can't open it.

In flent/settings.py:

> @@ -378,6 +378,12 @@ def __call__(self, parser, namespace, values, option_string=None):
     "to decrease the socket buffer size. Can be specified multiple times, "
     "with each value corresponding to a stream of a test.")
 
+test_group.add_argument(
+    "--test-payload",
+    action="store", type=unicode, dest="TEST_PAYLOAD", default='/dev/urandom',
+    help="Path to file containing payload to pre-fill the netperf buffers with"

Missing space at the end of the first string here

In flent/runners.py:

>                  # Sanity check; is /dev/urandom readable? If so, use it to
                 # pre-fill netperf's buffers
-                self.run_simple(['dd', 'if=/dev/urandom', 'of=/dev/null', 'bs=1', 'count=1'], errmsg="Err")
-                netperf['buffer'] = '-F /dev/urandom'
+                fillFile = args['test_payload']

Variables are generally lowercase and underscore-separated rather then camelCase...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_616f46edc9fdf_64d6c710710fc-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) by mail.toke.dk (Postfix) with ESMTPS id E63E38D3A7E for ; Wed, 20 Oct 2021 04:49:04 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=vbcFUEMZ Received: from github-lowworker-9bcb4a1.ac4-iad.github.net (github-lowworker-9bcb4a1.ac4-iad.github.net [10.52.25.84]) by smtp.github.com (Postfix) with ESMTP id DC2C3E0A4D for ; Tue, 19 Oct 2021 19:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634698143; bh=Rt0vFScg9uzArVtTVMIK0modqRdqSSdg0wVJD4AoJG8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vbcFUEMZqgBSoLDDOpfmAJD67GVhf8SpdcjknIed32Cvgw6ZMUj93YpgmeZvdf6ex DRT4WR+Mh/YIE6oKdxJTQRqO4TQ/80HBr8RsveEw9mcq65cjjTVHVh4Y93zJkR8Pb/ pPug2CqCxYp2J+ceBVKfeeYA85E3kVSpx7tKpwEs= Date: Tue, 19 Oct 2021 19:49:03 -0700 From: Hrishikesh Athalye To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_616f839fcdee6_6cfec710410089"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: hrishikeshathalye X-GitHub-Recipient: flent-users X-GitHub-Reason: push X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: TXVOPSJCGRH2UZV7CCE7OWPZTDAGJI7F X-Message-ID-Hash: TXVOPSJCGRH2UZV7CCE7OWPZTDAGJI7F X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Push X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_616f839fcdee6_6cfec710410089 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @hrishikeshathalye pushed 1 commit. c40bc60697802034e7bb0948c37783c357cd337b This commit adds a feature to give the user the option to specify -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/tohojo/flent/pull/243/files/ff214ce3ddf33ad8b441c2e8f8b8dc18135c2528..c40bc60697802034e7bb0948c37783c357cd337b ----==_mimepart_616f839fcdee6_6cfec710410089 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@hrishikeshathalye pushed 1 commit.

  • c40bc60 This commit adds a feature to give the user the option to specify

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_616f839fcdee6_6cfec710410089-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) by mail.toke.dk (Postfix) with ESMTPS id A1A1C8D4073 for ; Wed, 20 Oct 2021 16:50:57 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=CPhuJ1E7 Received: from github-lowworker-0f7e7fd.ash1-iad.github.net (github-lowworker-0f7e7fd.ash1-iad.github.net [10.56.110.17]) by smtp.github.com (Postfix) with ESMTP id 529F5600F10 for ; Wed, 20 Oct 2021 07:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634741456; bh=ihrsT40O+jxKY2TpgJg9xxgSUf+8sTOZbC4FdBmQ1ss=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CPhuJ1E7g+lSmMFfYyoXXWbE7J1X59XEA9lNhlM5bmXhZz1UFyBA6fKXUXwdIE9ti LHSjdJr2QTA/JAWNenCqkM9hW27x8Ja7Db9Lv9AQY43itwnemiBbGYTbQuWqwkfQ0M +eIC3oboePZRoSjdqd+Y4+P9WxtLPbg4NAO0OdS4= Date: Wed, 20 Oct 2021 07:50:56 -0700 From: Hrishikesh Athalye To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_61702cd04327e_1616c710291817"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: hrishikeshathalye X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: VHNT6L3GHOF2FNB3CUQBAMBCCJTVSUG4 X-Message-ID-Hash: VHNT6L3GHOF2FNB3CUQBAMBCCJTVSUG4 X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_61702cd04327e_1616c710291817 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thank you for the suggestions. Have modified the code accordingly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#issuecomment-947745301 ----==_mimepart_61702cd04327e_1616c710291817 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Thank you for the suggestions. Have modified the code accordingly.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_61702cd04327e_1616c710291817-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) by mail.toke.dk (Postfix) with ESMTPS id 50DA68D434A for ; Wed, 20 Oct 2021 23:20:55 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=eHxkUC8Y Received: from github-lowworker-bc343b9.ash1-iad.github.net (github-lowworker-bc343b9.ash1-iad.github.net [10.56.122.73]) by smtp.github.com (Postfix) with ESMTP id A8AEB900390 for ; Wed, 20 Oct 2021 14:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634764854; bh=ijky7nSsmLOypk1Z7tvNY/EIT63rIZZM+iaqLduLEz0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eHxkUC8YItbb5xzqLk37zyYNRklPsoZSdhiiBBxM8ZI+QiA14L5lU4759ByLFBHgo vHV6a81sNqOPrmFyW+BGhn3hQj/GKQblrGDETo6OxYxUR32X9pVoDIAcYwh2f3lAWE qc5xOnwUiP/uZRp/alNmrahUxHpMJP/mRmjExsEQ= Date: Wed, 20 Oct 2021 14:20:54 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_617088369a80c_315ac7101597fe"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: FAET35VOXNSGJ24PF4IS7PXRF3PTNZK6 X-Message-ID-Hash: FAET35VOXNSGJ24PF4IS7PXRF3PTNZK6 X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_617088369a80c_315ac7101597fe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @tohojo requested changes on this pull request. That's better! One more small nit below. Also, the commit message you added is great, but please squash the two commits together so that it becomes one commit that keeps the heading of the first one, and has the text of the second commit as its body. Also, this sentence: > Using the option will cause netperf to fail noisily, in case the specified file is not readable or does not exist. is slightly misleading. It's not netperf that fails noisily, it's the check in flent. So maybe "Flent will check if the file is readable before passing it to netperf, and fail the test run if it isn't" ? > except RunnerCheckError: - netperf['buffer'] = '' + if(fill_file == '/dev/urandom'): + netperf['buffer'] = '' + else: + # If the custom file is not readable, fail noisily + raise RunnerCheckError("The specified fill file does not exist or is not readable.") The option is --test-payload, so referring to "fill file" in the error message is going to confuse people. Better stick to "test payload" here as well :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#pullrequestreview-785005703 ----==_mimepart_617088369a80c_315ac7101597fe Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo requested changes on this pull request.

That's better! One more small nit below. Also, the commit message you added is great, but please squash the two commits together so that it becomes one commit that keeps the heading of the first one, and has the text of the second commit as its body.

Also, this sentence:

Using the option will cause netperf to fail noisily, in case the specified file is not readable or does not exist.

is slightly misleading. It's not netperf that fails noisily, it's the check in flent. So maybe "Flent will check if the file is readable before passing it to netperf, and fail the test run if it isn't" ?

In flent/runners.py:

>              except RunnerCheckError:
-                netperf['buffer'] = ''
+                if(fill_file == '/dev/urandom'):
+                    netperf['buffer'] = ''
+                else:
+                    # If the custom file is not readable, fail noisily
+                    raise RunnerCheckError("The specified fill file does not exist or is not readable.")

The option is --test-payload, so referring to "fill file" in the error message is going to confuse people. Better stick to "test payload" here as well :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_617088369a80c_315ac7101597fe-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-18.smtp.github.com [192.30.252.201]) by mail.toke.dk (Postfix) with ESMTPS id D26CB8D46CB for ; Thu, 21 Oct 2021 05:41:00 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=hh7UNDp3 Received: from github-lowworker-0f78100.ash1-iad.github.net (github-lowworker-0f78100.ash1-iad.github.net [10.56.25.48]) by smtp.github.com (Postfix) with ESMTP id 265833406C3 for ; Wed, 20 Oct 2021 20:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634787659; bh=tzC7K9xX6ORR+arpruPW+5D9ccICKJkuEmv5bOBvxAY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hh7UNDp3l/+6DS9iLfgvo5DU4uz4lSWayHa8ZvnyLlHr9AGTxXfdFMeTrMh/WTedh waeyx0P2N6jEuVS/nRrgMmKKlu86M8lQsmG/M5pc03mA/PhJL94CzVsLeqy8ZzwWrq oY0K9suMjsloCip2As5zVApccDJL50O3e9anhpok= Date: Wed, 20 Oct 2021 20:40:59 -0700 From: Hrishikesh Athalye To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6170e14b16c9a_3d70c710308865"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: hrishikeshathalye X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: URXPCZ4WW3N7NKWOPKDLVYISQBBG2MEA X-Message-ID-Hash: URXPCZ4WW3N7NKWOPKDLVYISQBBG2MEA X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6170e14b16c9a_3d70c710308865 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @hrishikeshathalye commented on this pull request. > except RunnerCheckError: - netperf['buffer'] = '' + if(fill_file == '/dev/urandom'): + netperf['buffer'] = '' + else: + # If the custom file is not readable, fail noisily + raise RunnerCheckError("The specified fill file does not exist or is not readable.") Ah yes. That would be more accurate. Edited. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#discussion_r733296393 ----==_mimepart_6170e14b16c9a_3d70c710308865 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@hrishikeshathalye commented on this pull request.

In flent/runners.py:

>              except RunnerCheckError:
-                netperf['buffer'] = ''
+                if(fill_file == '/dev/urandom'):
+                    netperf['buffer'] = ''
+                else:
+                    # If the custom file is not readable, fail noisily
+                    raise RunnerCheckError("The specified fill file does not exist or is not readable.")

Ah yes. That would be more accurate. Edited.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6170e14b16c9a_3d70c710308865-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) by mail.toke.dk (Postfix) with ESMTPS id F08C38D46E7 for ; Thu, 21 Oct 2021 05:41:28 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=kpc7WmZj Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id 5E5ABE0507 for ; Wed, 20 Oct 2021 20:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634787687; bh=hDJNvB1sm3YCsywTSdBgFplMcwHlPf9L45g8x9cxnEs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kpc7WmZjtbuo/ynamjaJBKnSoX+gmtb8+gdu2jqanIWDZDq2w+b1s/x6gcLTlZkne OmjGZBUaZoZsQLis+PhzxL1pI6PWhC+vuWaR3WZNOqpzmv7diguk/4n0d9mmVE2t5h P88MM39NrKUSDjb1kom5gyfYoVV1dRIEm5JfjI4s= Date: Wed, 20 Oct 2021 20:41:27 -0700 From: Hrishikesh Athalye To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6170e1674ff66_7595c710781b8"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: hrishikeshathalye X-GitHub-Recipient: flent-users X-GitHub-Reason: push X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: EKUYY2MSQGHM4XT7GXZYBY44PKNHL5CN X-Message-ID-Hash: EKUYY2MSQGHM4XT7GXZYBY44PKNHL5CN X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Push X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6170e1674ff66_7595c710781b8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @hrishikeshathalye pushed 1 commit. 42e0f29e50bf98a47ff961a3d677b537f8604c94 Added --test-payload option -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/tohojo/flent/pull/243/files/c46b8e76e768b6f9bda121af85cc5ba81773472c..42e0f29e50bf98a47ff961a3d677b537f8604c94 ----==_mimepart_6170e1674ff66_7595c710781b8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@hrishikeshathalye pushed 1 commit.

  • 42e0f29 Added --test-payload option

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6170e1674ff66_7595c710781b8-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-17.smtp.github.com [192.30.252.200]) by mail.toke.dk (Postfix) with ESMTPS id 160548D4B00 for ; Thu, 21 Oct 2021 12:40:20 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=H2q1D7Kk Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id A174A5C0210 for ; Thu, 21 Oct 2021 03:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634812819; bh=aNUjanoiAcULlfaSSG+xZ+gOvAR/TBo87wj8d/ER7Ow=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=H2q1D7KkI+2fBwOQrCssbBThYPdL75YCPyZMj4VyT7v2rcS60n0KNLj9p1203aroq cnkJTODLWAE/vi6GqFjni94XyGsvH/QR1anrL5FqzlOQptNvQwR8l80NdaFn7t2lx6 VeJXzZvPqNmz1aiJTvLPAabvPqj9afDnbjdWX9Fo= Date: Thu, 21 Oct 2021 03:40:19 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6171439392dd0_1e91c7102114a"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: UFAGQ535DTA6C3PC35W5TMYYYEO7ITVR X-Message-ID-Hash: UFAGQ535DTA6C3PC35W5TMYYYEO7ITVR X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6171439392dd0_1e91c7102114a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @tohojo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#pullrequestreview-785515354 ----==_mimepart_6171439392dd0_1e91c7102114a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6171439392dd0_1e91c7102114a-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) by mail.toke.dk (Postfix) with ESMTPS id AB2FD8D4B77 for ; Thu, 21 Oct 2021 13:20:29 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=S/DPPUH6 Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id 2BE0A840624 for ; Thu, 21 Oct 2021 04:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634815228; bh=l/XWrJHnUQS2snriX+PAOZKMcAweko/kpAJlfvH/42o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S/DPPUH6wFBFxBUC6zwdnRyvyHTTaGfwHDwsezS0ovg7PbXYhXyWxH0qp2eJot8Ue 1SdfgJ+RbYlVQeN8pqBbKEIIVUg7VGyHNCj1Z9Hog3VXFUAyJV1dYodOOcVZOpLMpY rGjDG56e0SOOQQZNtphuQ9qticUOMcoRuAmnyCxU= Date: Thu, 21 Oct 2021 04:20:28 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_61714cfc1c220_1f4ac710131599"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: XC6POQ2ZKXY5JZAC6H63RXCQGMOR5ZD6 X-Message-ID-Hash: XC6POQ2ZKXY5JZAC6H63RXCQGMOR5ZD6 X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_61714cfc1c220_1f4ac710131599 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Merged #243 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#event-5497802546 ----==_mimepart_61714cfc1c220_1f4ac710131599 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Merged #243 into master.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_61714cfc1c220_1f4ac710131599--