From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-18.smtp.github.com [192.30.252.201]) by mail.toke.dk (Postfix) with ESMTPS id D26CB8D46CB for ; Thu, 21 Oct 2021 05:41:00 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=hh7UNDp3 Received: from github-lowworker-0f78100.ash1-iad.github.net (github-lowworker-0f78100.ash1-iad.github.net [10.56.25.48]) by smtp.github.com (Postfix) with ESMTP id 265833406C3 for ; Wed, 20 Oct 2021 20:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1634787659; bh=tzC7K9xX6ORR+arpruPW+5D9ccICKJkuEmv5bOBvxAY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hh7UNDp3l/+6DS9iLfgvo5DU4uz4lSWayHa8ZvnyLlHr9AGTxXfdFMeTrMh/WTedh waeyx0P2N6jEuVS/nRrgMmKKlu86M8lQsmG/M5pc03mA/PhJL94CzVsLeqy8ZzwWrq oY0K9suMjsloCip2As5zVApccDJL50O3e9anhpok= Date: Wed, 20 Oct 2021 20:40:59 -0700 From: Hrishikesh Athalye To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6170e14b16c9a_3d70c710308865"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: hrishikeshathalye X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: URXPCZ4WW3N7NKWOPKDLVYISQBBG2MEA X-Message-ID-Hash: URXPCZ4WW3N7NKWOPKDLVYISQBBG2MEA X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6170e14b16c9a_3d70c710308865 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @hrishikeshathalye commented on this pull request. > except RunnerCheckError: - netperf['buffer'] = '' + if(fill_file == '/dev/urandom'): + netperf['buffer'] = '' + else: + # If the custom file is not readable, fail noisily + raise RunnerCheckError("The specified fill file does not exist or is not readable.") Ah yes. That would be more accurate. Edited. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/243#discussion_r733296393 ----==_mimepart_6170e14b16c9a_3d70c710308865 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@hrishikeshathalye commented on this pull request.

In flent/runners.py:

>              except RunnerCheckError:
-                netperf['buffer'] = ''
+                if(fill_file == '/dev/urandom'):
+                    netperf['buffer'] = ''
+                else:
+                    # If the custom file is not readable, fail noisily
+                    raise RunnerCheckError("The specified fill file does not exist or is not readable.")

Ah yes. That would be more accurate. Edited.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6170e14b16c9a_3d70c710308865--