Flent-users discussion archives
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243)
Date: Wed, 20 Oct 2021 14:20:54 -0700	[thread overview]
Message-ID: <tohojo/flent/pull/243/review/785005703@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/243@github.com>

[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

@tohojo requested changes on this pull request.

That's better! One more small nit below. Also, the commit message you added is great, but please squash the two commits together so that it becomes one commit that keeps the heading of the first one, and has the text of the second commit as its body.

Also, this sentence:

> Using the option will cause netperf to fail noisily, in case the specified file is not readable or does not exist.

is slightly misleading. It's not netperf that fails noisily, it's the check in flent. So maybe "Flent will check if the file is readable before passing it to netperf, and fail the test run if it isn't" ?

>              except RunnerCheckError:
-                netperf['buffer'] = ''
+                if(fill_file == '/dev/urandom'):
+                    netperf['buffer'] = ''
+                else:
+                    # If the custom file is not readable, fail noisily
+                    raise RunnerCheckError("The specified fill file does not exist or is not readable.")

The option is --test-payload, so referring to "fill file" in the error message is going to confuse people. Better stick to "test payload" here as well :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/243#pullrequestreview-785005703

[-- Attachment #2: Type: text/html, Size: 2907 bytes --]

  parent reply	other threads:[~2021-10-20 21:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 20:11 [Flent-users] " Hrishikesh Athalye
2021-10-19 22:30 ` [Flent-users] " Toke Høiland-Jørgensen
2021-10-20  2:49 ` Hrishikesh Athalye
2021-10-20 14:50 ` Hrishikesh Athalye
2021-10-20 21:20 ` Toke Høiland-Jørgensen [this message]
2021-10-21  3:40 ` Hrishikesh Athalye
2021-10-21  3:41 ` Hrishikesh Athalye
2021-10-21 10:40 ` Toke Høiland-Jørgensen
2021-10-21 11:20 ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tohojo/flent/pull/243/review/785005703@github.com \
    --to=notifications@github.com \
    --cc=flent@noreply.github.com \
    --cc=reply+AHVNJP3VMZ4BIEVTCD7MB3N7PRUTNEVBNHHD23Z4NQ@reply.github.com \
    --cc=subscribed@noreply.github.com \
    --subject='[Flent-users] Re: [tohojo/flent] Added --test-payload option (PR #243)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox