From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) by mail.toke.dk (Postfix) with ESMTPS id 8552F8C5619 for ; Wed, 29 Sep 2021 14:32:32 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=KV6AT5SO Received: from github-lowworker-18092a0.ac4-iad.github.net (github-lowworker-18092a0.ac4-iad.github.net [10.52.123.83]) by smtp.github.com (Postfix) with ESMTP id 53652560799 for ; Wed, 29 Sep 2021 05:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1632918751; bh=oVFP6Y+NFIs9yQhdBzHTe+wrz01/un61XDNs7ukbUj4=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=KV6AT5SOTqml9X3HbgHpw/0xYZKpIcqhHETKYqHoYQmruAQy1ZbWrYaE2HA3ABKA2 zS+2BukXzm8BG4rjjdECJ26QLqd0jtz0fSUdSUX8Dihhx9lx+qGtl1ZnK45dZQZ3a8 XPTeu0XFGmb2HVZO88VIeXqIDB19gv9oBnTUVqKU= Date: Wed, 29 Sep 2021 05:32:31 -0700 From: Pete Heist To: tohojo/flent Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_61545cdf44748_3f38c7603059e"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: JYFJG6QWVH3IMI4GF5MO7YKBDTUBOVMI X-Message-ID-Hash: JYFJG6QWVH3IMI4GF5MO7YKBDTUBOVMI X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_61545cdf44748_3f38c7603059e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit irtt currently only accepts IPv6 addresses surrounded by brackets. If the host contains an IPv6 address literal (as identified by ipaddress.IPv6Address), surround the host with brackets before passing to irtt. This should address #238. You can view, comment on, or merge this pull request online at: https://github.com/tohojo/flent/pull/239 -- Commit Summary -- * runners: Bracket IPv6 addresses before passing to irtt -- File Changes -- M flent/runners.py (17) -- Patch Links -- https://github.com/tohojo/flent/pull/239.patch https://github.com/tohojo/flent/pull/239.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239 ----==_mimepart_61545cdf44748_3f38c7603059e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

irtt currently only accepts IPv6 addresses surrounded by brackets.
If the host contains an IPv6 address literal (as identified by
ipaddress.IPv6Address), surround the host with brackets before
passing to irtt.

This should address #238.

You can view, comment on, or merge this pull request online at:

  https://github.com/tohojo/flent/pull/239

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_61545cdf44748_3f38c7603059e-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) by mail.toke.dk (Postfix) with ESMTPS id 65E268C5B87 for ; Wed, 29 Sep 2021 23:51:41 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=AMmF3WPl Received: from github-lowworker-98efffe.ac4-iad.github.net (github-lowworker-98efffe.ac4-iad.github.net [10.52.122.80]) by smtp.github.com (Postfix) with ESMTP id 635AE840E4A for ; Wed, 29 Sep 2021 14:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1632952300; bh=Z3hnfpckTf7Kre06qe0jB51tcGalWENx2WwrjT9ntSU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AMmF3WPlirKFS4lqCQdQnHOPQvIsVmWV9EQEJ0otfSOQIk1CLCNTSBnNf0qUGAqFr Q+SKDH7QgZk9b8qei3SlpJbI2ltLwOhdpHt0SC9ztkVB550kgLAS7tzc5FiOOMtz2P TyfUiYgttoQ6tHv0xa6WnicEu1ymAL4NMYpjSgLs= Date: Wed, 29 Sep 2021 14:51:40 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6154dfec520cc_3526c7602403ec"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: OHDQWINTBXSLHOXKFSAXTHJOW66K5TXR X-Message-ID-Hash: OHDQWINTBXSLHOXKFSAXTHJOW66K5TXR X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6154dfec520cc_3526c7602403ec Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @tohojo requested changes on this pull request. > @@ -1682,7 +1683,13 @@ def check(self): if self.ip_version is not None: args.append("-{}".format(self.ip_version)) - args.append(self.host) + try: + ipaddress.IPv6Address(self.host) + host = "[{}]".format(self.host) + except ValueError: + host = self.host Using the ipaddress module for parsing is fine, but let's move this into the normalise_host() utility function. Simply adding a second argument 'bracket_v6' which defaults to 'False' to that should do the trick :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#pullrequestreview-767221497 ----==_mimepart_6154dfec520cc_3526c7602403ec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo requested changes on this pull request.

In flent/runners.py:

> @@ -1682,7 +1683,13 @@ def check(self):
             if self.ip_version is not None:
                 args.append("-{}".format(self.ip_version))
 
-            args.append(self.host)
+            try:
+                ipaddress.IPv6Address(self.host)
+                host = "[{}]".format(self.host)
+            except ValueError:
+                host = self.host

Using the ipaddress module for parsing is fine, but let's move this into the normalise_host() utility function. Simply adding a second argument 'bracket_v6' which defaults to 'False' to that should do the trick :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6154dfec520cc_3526c7602403ec-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) by mail.toke.dk (Postfix) with ESMTPS id 587B58C6136 for ; Thu, 30 Sep 2021 08:38:37 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=1bt5AKec Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id 06597560B5D for ; Wed, 29 Sep 2021 23:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1632983917; bh=k1IOrHrQvqFsgxiNcnp0zI2jw/ZcPandJO3jhewlc58=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1bt5AKecBxBb2a6hjEmfyeelyZIOonozuSjnDlz74D8bhRfyYI7bZmmY5xKR4TStI vVHlZFXU3Rf0WhubFpavuCuTLYFs5Q8NPgzm4ZMLNrj3WEsZir/7kyKvZwPYb+hOQW OXeywbNNql+3Wzo2hYqKPW6JjF0lbC2BdPkCgOzA= Date: Wed, 29 Sep 2021 23:38:36 -0700 From: Pete Heist To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_61555b6ceaf68_1becc760129789"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: push X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: TTM2HX3T37UEZ75G7MVBKQFLOUF5M6ZX X-Message-ID-Hash: TTM2HX3T37UEZ75G7MVBKQFLOUF5M6ZX X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Push X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_61555b6ceaf68_1becc760129789 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @heistp pushed 1 commit. 7d7a6ac0c5aeef4206d6d43afe735d92adeb18bc util: Add optional bracket_v6 parameter to normalise_host -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/tohojo/flent/pull/239/files/1ac5b086854e5b0fe8a6b944b12aa03aa5ed0257..7d7a6ac0c5aeef4206d6d43afe735d92adeb18bc ----==_mimepart_61555b6ceaf68_1becc760129789 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@heistp pushed 1 commit.

  • 7d7a6ac util: Add optional bracket_v6 parameter to normalise_host

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_61555b6ceaf68_1becc760129789-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) by mail.toke.dk (Postfix) with ESMTPS id 84BF38C614D for ; Thu, 30 Sep 2021 08:40:12 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=ZLZF2jM3 Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id B389C900EB3 for ; Wed, 29 Sep 2021 23:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1632984011; bh=6U6Ho/t6+RbD9xhrt520CK2rmdmy0Wjvz+4dZAQZFNA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZLZF2jM3+sZMGYoW10NnyF3gdNHz7v4xHz7Z3qS3ENdMG/gmpTlOV6pFInjReRtRl 61rVgy/fGDqq9xnF0THbuMomba8b4k7Pkmr9uzu3wsOKhRhaC5lN2VtyvXei3gw8+m Nq+neo8z0+utLycrrNHAJ09B1Ue+min7tEQp4Avk= Date: Wed, 29 Sep 2021 23:40:11 -0700 From: Pete Heist To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_61555bcba611a_3214c760816bb"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: OWNX4JHO3FZOZQ2UDNQT6TGML776CKIV X-Message-ID-Hash: OWNX4JHO3FZOZQ2UDNQT6TGML776CKIV X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_61555bcba611a_3214c760816bb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @heistp commented on this pull request. > @@ -1682,7 +1683,13 @@ def check(self): if self.ip_version is not None: args.append("-{}".format(self.ip_version)) - args.append(self.host) + try: + ipaddress.IPv6Address(self.host) + host = "[{}]".format(self.host) + except ValueError: + host = self.host Ah, I didn't notice that, that's a much better solution. :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#discussion_r719101580 ----==_mimepart_61555bcba611a_3214c760816bb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@heistp commented on this pull request.

In flent/runners.py:

> @@ -1682,7 +1683,13 @@ def check(self):
             if self.ip_version is not None:
                 args.append("-{}".format(self.ip_version))
 
-            args.append(self.host)
+            try:
+                ipaddress.IPv6Address(self.host)
+                host = "[{}]".format(self.host)
+            except ValueError:
+                host = self.host

Ah, I didn't notice that, that's a much better solution. :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_61555bcba611a_3214c760816bb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) by mail.toke.dk (Postfix) with ESMTPS id AC40B8C61C6 for ; Thu, 30 Sep 2021 09:12:30 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=InFOba8a Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id 80E8F560F02 for ; Thu, 30 Sep 2021 00:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1632985949; bh=f826OV5i3U1jtSXbsXEMFJeCp33AJ5HliAWeK88vUAo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=InFOba8aPS8IgJ0I+CEsEznhYdUmst91Be6+KcaY/uL4qGtvr7RSgW75h8mw0VDcn nvR7QL4R4RJP+l33uQzqcMezqJIUFm71RNm3pKmDe1D8j2jzkbCOJafuu8fdlvSHqZ NB0zBRLOgVLqscc/SvvVXvQdyVwX+cAyobT9YMQw= Date: Thu, 30 Sep 2021 00:12:29 -0700 From: Pete Heist To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6155635d72ab9_52dfc76011237"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: push X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: 53K7EXYEGJREXDYW43WVOPURAIYWTJEY X-Message-ID-Hash: 53K7EXYEGJREXDYW43WVOPURAIYWTJEY X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Push X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6155635d72ab9_52dfc76011237 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @heistp pushed 1 commit. d4f2adf4663fdef1781413b4392d18edd9cc47d8 irtt: pass bracket_v6 as an explicitly named parameter -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/tohojo/flent/pull/239/files/7d7a6ac0c5aeef4206d6d43afe735d92adeb18bc..d4f2adf4663fdef1781413b4392d18edd9cc47d8 ----==_mimepart_6155635d72ab9_52dfc76011237 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@heistp pushed 1 commit.

  • d4f2adf irtt: pass bracket_v6 as an explicitly named parameter

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6155635d72ab9_52dfc76011237-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) by mail.toke.dk (Postfix) with ESMTPS id A7FB38C61E1 for ; Thu, 30 Sep 2021 09:15:48 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=1F0ME+rr Received: from github-lowworker-3d542c1.va3-iad.github.net (github-lowworker-3d542c1.va3-iad.github.net [10.48.123.81]) by smtp.github.com (Postfix) with ESMTP id 65B3DE0F45 for ; Thu, 30 Sep 2021 00:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1632986147; bh=VcLRDXuO9l52/KyRQzfC8o4F68dfzN3RQRXSU/irPOc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1F0ME+rraO2MOdJfsh7cQBvzCtgwsKOPLzHG/8D3useyvCNVkYsA5lopkrbte6LuQ IqA/Y/kkq6Ho7gfO87nYTy9dcJuJvBtmmvfHwYgFTamp5tvKUBjCDQBWtcExA9buHb +z/RBqabRCUSxaY5LgnTgHwuM7/P49i/yBum/ALo= Date: Thu, 30 Sep 2021 00:15:47 -0700 From: Pete Heist To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6155642357ac6_28c7c76014725b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: 2Y43RLLWNMUBS22JIILX5IANQRC53L3M X-Message-ID-Hash: 2Y43RLLWNMUBS22JIILX5IANQRC53L3M X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6155642357ac6_28c7c76014725b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @heistp commented on this pull request. > @@ -1682,7 +1683,13 @@ def check(self): if self.ip_version is not None: args.append("-{}".format(self.ip_version)) - args.append(self.host) + try: + ipaddress.IPv6Address(self.host) + host = "[{}]".format(self.host) + except ValueError: + host = self.host It just occurred to me that when adding optional parameters, it might be good practice to specify them by name in calls to those functions, so I updated that. I don't know what normal python practice is. I guess as long as the parameter positions don't change it's not critical, but this might also make it more apparent what you're doing in the call itself. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#discussion_r719123312 ----==_mimepart_6155642357ac6_28c7c76014725b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@heistp commented on this pull request.

In flent/runners.py:

> @@ -1682,7 +1683,13 @@ def check(self):
             if self.ip_version is not None:
                 args.append("-{}".format(self.ip_version))
 
-            args.append(self.host)
+            try:
+                ipaddress.IPv6Address(self.host)
+                host = "[{}]".format(self.host)
+            except ValueError:
+                host = self.host

It just occurred to me that when adding optional parameters, it might be good practice to specify them by name in calls to those functions, so I updated that. I don't know what normal python practice is. I guess as long as the parameter positions don't change it's not critical, but this might also make it more apparent what you're doing in the call itself.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6155642357ac6_28c7c76014725b-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) by mail.toke.dk (Postfix) with ESMTPS id 9F62E8C64A0 for ; Thu, 30 Sep 2021 13:12:48 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=SHnWRmPn Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id 84F3AE08FD for ; Thu, 30 Sep 2021 04:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1633000367; bh=GgvaP5hECuAZnuAmDLsETdve18V5wpYdHLtwBaKH87o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SHnWRmPn/sSjJLEvq9YXS6rgyiFZ7bAljIub2wZ+LX7hCqUeZdLZ9lxtCJ0VzLRg1 A8Ghb/YYyPLCuEInFiAwMlfFplW+Xs3NObMN+tCDtvY6QNxX3qojFIb/+xuZHS06Ef lnihlS/KRBppaGBx48IBygq8tzlszH9KradWkzho= Date: Thu, 30 Sep 2021 04:12:47 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_61559baf76e90_c58c76067437a"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: 5MPYFWCCQNIF46L34PZ6KRQUOAPOKPWH X-Message-ID-Hash: 5MPYFWCCQNIF46L34PZ6KRQUOAPOKPWH X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_61559baf76e90_c58c76067437a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @tohojo approved this pull request. LGTM, but could you please squash the changes into a single commit? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#pullrequestreview-767718801 ----==_mimepart_61559baf76e90_c58c76067437a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo approved this pull request.

LGTM, but could you please squash the changes into a single commit? :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_61559baf76e90_c58c76067437a-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) by mail.toke.dk (Postfix) with ESMTPS id CF5318C669A for ; Thu, 30 Sep 2021 15:27:48 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=rkMgxXe2 Received: from github-lowworker-ca235ff.ash1-iad.github.net (github-lowworker-ca235ff.ash1-iad.github.net [10.56.110.15]) by smtp.github.com (Postfix) with ESMTP id 94D9BE0A96 for ; Thu, 30 Sep 2021 06:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1633008467; bh=ItYdUUmNr7KHae3PBgnM/jGUqXQ4bxsq9hHH9MUx2jg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rkMgxXe2phWdWMvhma/4+SxejLiA4MOWlfsNpJLOB0NT3QlxwY9bCSDogVifqAUJu gDwECg/R8y34wQArYgoTAyr2NisXpQ9OOxFKtdRXC/sGwY6JwFCHRwRRqhXyX7VmI3 kPBOILNWbBsw7GvW1JemgWShUNJ/XT8CMsaFxAtA= Date: Thu, 30 Sep 2021 06:27:47 -0700 From: Pete Heist To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6155bb5386eaf_7f0ac76078295"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: heistp X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: BNMWHVXW3QMDCLEDOYI6MLS76C3RHEJV X-Message-ID-Hash: BNMWHVXW3QMDCLEDOYI6MLS76C3RHEJV X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6155bb5386eaf_7f0ac76078295 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > LGTM, but could you please squash the changes into a single commit? :) Squashed and force pushed, so hopefully that's fine. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#issuecomment-931322575 ----==_mimepart_6155bb5386eaf_7f0ac76078295 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

LGTM, but could you please squash the changes into a single commit? :)

Squashed and force pushed, so hopefully that's fine.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6155bb5386eaf_7f0ac76078295-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) by mail.toke.dk (Postfix) with ESMTPS id C4AD68C66F8 for ; Thu, 30 Sep 2021 15:56:56 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=O01sadLr Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id BD53D840E11 for ; Thu, 30 Sep 2021 06:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1633010215; bh=BKSWtsKazXDWqSw916ZovXm8SKyK5kaEiWu4Gpuols4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=O01sadLrCBFf75KYVYzJBDaQWUGkGZekdNXKvPP23ts8JulowepTqdAe6mfbPJCZj XjplYfAWwcrcBXm0xbv4Lp+nC3mEJ0UVnJUwJqe9G421KhBX+dC1Yg0f+TiIDQG4zD pe4S8+9vgOyuzo1xqSoq5MdLerVxHcfucm+xhp4c= Date: Thu, 30 Sep 2021 06:56:55 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6155c227af62b_4a5cc760943da"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: ZKUYIZU2AXKJAITJKJD4BZLX3KSEWYYU X-Message-ID-Hash: ZKUYIZU2AXKJAITJKJD4BZLX3KSEWYYU X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6155c227af62b_4a5cc760943da Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Merged #239 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#event-5387927802 ----==_mimepart_6155c227af62b_4a5cc760943da Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Merged #239 into master.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6155c227af62b_4a5cc760943da-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) by mail.toke.dk (Postfix) with ESMTPS id 3D5388C6720 for ; Thu, 30 Sep 2021 15:59:04 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=NDgpBWGX Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 53D3B600D88 for ; Thu, 30 Sep 2021 06:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1633010343; bh=H40bzZajqhcCry1P6OBikFwMt1Y0+fVqNP7iDxFjHac=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NDgpBWGXi27zqMxuKsUyKu1F2/HfYbszMhF5axvHZ+1AgJdyTOCj9KnnZ8X8uTiUj bpQCEfWki8/co6UmBGoQk7hmM/gsuFiBCxu/worqsuSRUVBEwXJWeiu9rUNIfaqBqD Dp2rQbU1mhh5SPbzKzu22bG49vKTzfo8P5/e/+Rw= Date: Thu, 30 Sep 2021 06:59:03 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_6155c2a746256_714ac7602002d"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Message-ID-Hash: I4YOQXZLBBAO657XLHJJMNRQY7HNS2NQ X-Message-ID-Hash: I4YOQXZLBBAO657XLHJJMNRQY7HNS2NQ X-MailFrom: noreply@github.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Subscribed X-Mailman-Version: 3.3.4 Reply-To: tohojo/flent Subject: [Flent-users] Re: [tohojo/flent] runners: Bracket IPv6 addresses before passing to irtt (#239) List-Id: Flent discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ----==_mimepart_6155c2a746256_714ac7602002d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Awesome - thanks! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/239#issuecomment-931348708 ----==_mimepart_6155c2a746256_714ac7602002d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Awesome - thanks! :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

----==_mimepart_6155c2a746256_714ac7602002d--