From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202])
	by mail.toke.dk (Postfix) with ESMTPS id D3DE88CF99D
	for <flent-users@flent.org>; Wed, 13 Oct 2021 20:12:48 +0200 (CEST)
Authentication-Results: mail.toke.dk;
	dkim=pass (1024-bit key) header.d=github.com header.i=@github.com header.b=PqXsegY2
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98])
	by smtp.github.com (Postfix) with ESMTP id 0248FE050F
	for <flent-users@flent.org>; Wed, 13 Oct 2021 11:12:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
	s=pf2014; t=1634148768;
	bh=gK06xxsbcto+fFQHBIt7H6lhtiHXN/OcMnlGCnflGaM=;
	h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
	 List-Archive:List-Post:List-Unsubscribe:From;
	b=PqXsegY2Dwyd7Ljmws9PF2hpQ42/B2Ofs59CsAPwmqcbv3YMg2Y8bHrc76wiPD9in
	 Drm4kKVnYY3j/8fR5dJA5FHlH/J3JKuh46V6ptdQjL2FORYV1n9L+iltppA3nHbcVR
	 xj3ORlLuckIaJUgarSCDkRbxVO49WEP9udDM7m0c=
Date: Wed, 13 Oct 2021 11:12:47 -0700
From: Shashank D <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Message-ID: <tohojo/flent/pull/237/review/778935467@github.com>
In-Reply-To: <tohojo/flent/pull/237@github.com>
References: <tohojo/flent/pull/237@github.com>
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_6167219fe5f7f_1432c71016375d";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: shashank68
X-GitHub-Recipient: flent-users
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: flent-users@flent.org
Message-ID-Hash: RNQ6RN4B5Q5DFJY46ECU3U4KJ6NQ2KKA
X-Message-ID-Hash: RNQ6RN4B5Q5DFJY46ECU3U4KJ6NQ2KKA
X-MailFrom: noreply@github.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: Subscribed <subscribed@noreply.github.com>
X-Mailman-Version: 3.3.4
Reply-To: tohojo/flent <reply+AHVNJP37GYYZUFMWJYAV4I57OMBJ7EVBNHHDYDG56Q@reply.github.com>
Subject: [Flent-users] Re: [tohojo/flent] Runners: stop stats collection iterators after test-time is completed (#237)
List-Id: Flent discussion list <flent-users.flent.org>
Archived-At: <https://lists.flent.org/flent-users/tohojo/flent/pull/237/review/778935467@github.com/>
List-Archive: <https://lists.flent.org/flent-users/>
List-Help: <mailto:flent-users-request@flent.org?subject=help>
List-Owner: <mailto:flent-users-owner@flent.org>
List-Post: <mailto:flent-users@flent.org>
List-Subscribe: <mailto:flent-users-join@flent.org>
List-Unsubscribe: <mailto:flent-users-leave@flent.org>


----==_mimepart_6167219fe5f7f_1432c71016375d
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@shashank68 commented on this pull request.



> @@ -41,7 +41,8 @@ then
 fi
 
 command_string=$(cat <<EOF
-for i in \$(seq $count); do
+endtime=\$(date -d "\$length sec" +%s%N);

Oh, But wouldn't it be better if the endtime was calculated in the remote host (For e.g if ssh took few seconds to connect, then the stats collection time will be reduced) or am I missing something?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/237#discussion_r728330344
----==_mimepart_6167219fe5f7f_1432c71016375d
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@shashank68</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/tohojo/flent/pull/237#discussion_r728330344">flent/scripts/ss_iterate.sh</a>:</p>
<pre style='color:#555'>&gt; @@ -41,7 +41,8 @@ then
 fi
 
 command_string=$(cat &lt;&lt;EOF
-for i in \$(seq $count); do
+endtime=\$(date -d &quot;\$length sec&quot; +%s%N);
</pre>
<p>Oh, But wouldn't it be better if the endtime was calculated in the remote host (For e.g if ssh took few seconds to connect, then the stats collection time will be reduced) or am I missing something?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/tohojo/flent/pull/237#discussion_r728330344">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AHVNJP2DTYMDBEKAXWIE5UTUGXDZ7ANCNFSM5EZCV33A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&amp;mt=8&amp;pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&amp;referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AHVNJP6AZ2C3UFNTJIFO6RTUGXDZ7A5CNFSM5EZCV33KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFZWZZKY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/tohojo/flent/pull/237#discussion_r728330344",
"url": "https://github.com/tohojo/flent/pull/237#discussion_r728330344",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_6167219fe5f7f_1432c71016375d--