From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from mail.toke.dk by mail.toke.dk with LMTP id m62FMakB5V2CSwwAOr1fkg (envelope-from ) for ; Mon, 02 Dec 2019 13:20:57 +0100 Authentication-Results: mail.toke.dk; none (SPF check N/A for local connections - client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=yolls5ge Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id AF93D6BCE10 for ; Mon, 2 Dec 2019 13:20:48 +0100 (CET) Received: from [::1] (port=59496 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.92) (envelope-from ) id 1ibkh5-000aFr-Hd; Mon, 02 Dec 2019 14:20:47 +0200 Received: from out-24.smtp.github.com ([192.30.252.207]:39907) by web6.sd.eurovps.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ibkgv-000a7T-5d for flent-users@flent.org; Mon, 02 Dec 2019 14:20:44 +0200 Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id 24AC16A1D70 for ; Mon, 2 Dec 2019 04:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575289195; bh=B5LvcwuxTKp90GsZNAbYcahz2na3ITOqXmi0hamOnsQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yolls5geXzSP68mSfFxWfCoHG1p/4slS/TL1KtzzJq5KXmVojxcidPVk3VgAws3YB FYfjMVqKQ+ii5BmJlYwQFWeJ7ckfSsTx/rh4g79OwRUwCbQ8dTqoRxLg1K+u0qJs+y 0wmv0+UJgc8pqmX6a9FQF1I52BEuynmK4Z6OthnI= Date: Mon, 02 Dec 2019 04:19:55 -0800 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: Re: [Flent-users] [tohojo/flent] metadata: Add parsing of WiFi status information (#192) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.29 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Subscribed Content-Type: multipart/mixed; boundary="===============8797502801987621667==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============8797502801987621667== Content-Type: multipart/alternative; boundary="--==_mimepart_5de5016b16b9e_1ea73fc48b8cd964585396"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5de5016b16b9e_1ea73fc48b8cd964585396 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit tohojo approved this pull request. The changes look good now, great work! :) It seems there are two commits in the pull request; I guess you created a new one instead of amending the original one? I can fix this and squash them together when merging, but just something to be aware of next time :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/pull/192#pullrequestreview-325199679 ----==_mimepart_5de5016b16b9e_1ea73fc48b8cd964585396 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@tohojo approved this pull request.

The changes look good now, great work! :)

It seems there are two commits in the pull request; I guess you created a new one instead of amending the original one? I can fix this and squash them together when merging, but just something to be aware of next time :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5de5016b16b9e_1ea73fc48b8cd964585396-- --===============8797502801987621667== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============8797502801987621667==--