From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] added wifi data function (#188)
Date: Fri, 15 Nov 2019 06:09:15 -0800 [thread overview]
Message-ID: <tohojo/flent/pull/188/review/317638423@github.com> (raw)
In-Reply-To: <tohojo/flent/pull/188@github.com>
[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]
tohojo commented on this pull request.
> @@ -514,3 +514,27 @@ def get_module_versions():
module_versions[m] = v
return module_versions
+
+def get_wifi_data(iface):
You added a new function. But it doesn't do anything until you add some code that calls that function and does something with the result. Look at the how get_ip_addrs() is being called in record_metadata() for an example...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/188#discussion_r346838936
[-- Attachment #1.2: Type: text/html, Size: 2154 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org
next prev parent reply other threads:[~2019-11-15 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tohojo/flent/pull/188@github.com>
2019-11-06 21:55 ` Toke Høiland-Jørgensen
2019-11-15 14:09 ` Toke Høiland-Jørgensen [this message]
2019-11-15 14:09 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tohojo/flent/pull/188/review/317638423@github.com \
--to=notifications@github.com \
--cc=flent@noreply.github.com \
--cc=reply+AHVNJPYNBNMJ5BCH3J6YMZF33PSAXEVBNHHB5S2VX4@reply.github.com \
--cc=subscribed@noreply.github.com \
--subject='Re: [Flent-users] [tohojo/flent] added wifi data function (#188)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox