Flent-users discussion archives
 help / color / mirror / Atom feed
* [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164)
@ 2019-06-28  8:38 Rémi Pauchet
  2019-06-28 10:00 ` Toke Høiland-Jørgensen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rémi Pauchet @ 2019-06-28  8:38 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]

When using remote-host option to run stream generators on another hosts, the commands are executed on the same host flent is running. The commands are prefixed with ssh, but the forked process run self.args which is defined just before the update.
You can view, comment on, or merge this pull request online at:

  https://github.com/tohojo/flent/pull/164

-- Commit Summary --

  * Fix executed command when using remote-host option

-- File Changes --

    M flent/runners.py (3)

-- Patch Links --

https://github.com/tohojo/flent/pull/164.patch
https://github.com/tohojo/flent/pull/164.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/164

[-- Attachment #1.2: Type: text/html, Size: 2427 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164)
  2019-06-28  8:38 [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164) Rémi Pauchet
@ 2019-06-28 10:00 ` Toke Høiland-Jørgensen
  2019-06-28 10:00 ` Toke Høiland-Jørgensen
  2019-06-28 10:01 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-06-28 10:00 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

Thanks for the report, and fix!

There were a few style issues with the pull request (missing DCO, no commit
message, you forgot to move the metadata saving of the command), so I just
committed this fix instead of merging the pull request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/164#issuecomment-506678837

[-- Attachment #1.2: Type: text/html, Size: 1813 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164)
  2019-06-28  8:38 [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164) Rémi Pauchet
  2019-06-28 10:00 ` Toke Høiland-Jørgensen
@ 2019-06-28 10:00 ` Toke Høiland-Jørgensen
  2019-06-28 10:01 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-06-28 10:00 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 192 bytes --]

Closed #164.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/164#event-2446844848

[-- Attachment #1.2: Type: text/html, Size: 1960 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164)
  2019-06-28  8:38 [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164) Rémi Pauchet
  2019-06-28 10:00 ` Toke Høiland-Jørgensen
  2019-06-28 10:00 ` Toke Høiland-Jørgensen
@ 2019-06-28 10:01 ` Toke Høiland-Jørgensen
  2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-06-28 10:01 UTC (permalink / raw)
  To: tohojo/flent; +Cc: Subscribed


[-- Attachment #1.1: Type: text/plain, Size: 235 bytes --]

Fixed in 276abd7e28d264e76d8b739f7e3867710cfbedbc

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/164#issuecomment-506679032

[-- Attachment #1.2: Type: text/html, Size: 1839 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-28 10:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28  8:38 [Flent-users] [tohojo/flent] Fix executed command when using remote-host option (#164) Rémi Pauchet
2019-06-28 10:00 ` Toke Høiland-Jørgensen
2019-06-28 10:00 ` Toke Høiland-Jørgensen
2019-06-28 10:01 ` Toke Høiland-Jørgensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox