From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [Flent-users] Re: [tohojo/flent] ss_iterate.sh unnecessarily runs for a long time (#236)
Date: Tue, 14 Sep 2021 03:46:50 -0700 [thread overview]
Message-ID: <tohojo/flent/issues/236/919035245@github.com> (raw)
In-Reply-To: <tohojo/flent/issues/236@github.com>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
Shashank D ***@***.***> writes:
>> Hmm, good question. So you're just running ss in a busy loop, or did you keep the 'sleep'? If so, that seems a bit excessive to do by default.
> Yes I did keep the sleep in the loop. Here's the full loop:
> ```bash
> command_string=$(cat <<EOF
> duration="$(echo "$count*$interval" | bc) sec";
> endtime=\$(date -d "\$duration" +%s%N);
> while (( \$(date +%s%N) <= \$endtime )); do
> ss -t -i -p -n state connected "dst $target $filter"
> echo ''
> date '+Time: %s.%N';
> echo "---";
> sleep $interval || exit 1;
> done
> EOF
> )
> ```
Right, makes sense. Feel free to open a PR with this, but please lose
the dependency on 'bc'. Either do the math in native shell, or just pass
the duration as a parameter from Flent.
Did you test whether this works on OpenWrt and on Dash?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/236#issuecomment-919035245
[-- Attachment #2: Type: text/html, Size: 2521 bytes --]
next prev parent reply other threads:[~2021-09-14 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 16:18 [Flent-users] " Shashank D
2021-09-13 11:48 ` [Flent-users] " Toke Høiland-Jørgensen
2021-09-14 7:38 ` Shashank D
2021-09-14 10:46 ` Toke Høiland-Jørgensen [this message]
2021-09-14 16:14 ` Shashank D
2021-09-14 20:46 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tohojo/flent/issues/236/919035245@github.com \
--to=notifications@github.com \
--cc=flent@noreply.github.com \
--cc=reply+AHVNJPZA4DVRNIW5OR2JXKF7JRPJVEVBNHHDWFR3SE@reply.github.com \
--cc=subscribed@noreply.github.com \
--subject='[Flent-users] Re: [tohojo/flent] ss_iterate.sh unnecessarily runs for a long time (#236)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox