[Flent-users] [tohojo/flent] Plots are broken somehow (#227)

[Flent-users] [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

v2.0.0 Release is wonderful and has a lot of improvements.
But currently plotting bug is present.
For some reasons combined plots such as "totals" are shifted. I mean graphs are not aligned.

Command to reproduce:
flent --input some_test_file.flent --plot totals --bounds-x 300 --figure-width 26 --figure-height 14 --zero-y --no-title --bounds-y=500 --output ./test_totals.png

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227

[-- Attachment #2: Type: text/html, Size: 1403 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

![test_totals](https://user-images.githubusercontent.com/6944552/122762601-ebfc6680-d2b6-11eb-83e9-ba678c82199c.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-864997002

[-- Attachment #2: Type: text/html, Size: 1400 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Toke Høiland-Jørgensen]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

Could you please test if this issue is still present in the git version?
You could just do:

git clone https://github.com/tohojo/flent
cd flent
./run-flent --input some_test_file.flent --plot totals --bounds-x 300 --figure-width 26 --figure-height 14 --zero-y --no-title --bounds-y=500 --output ./test_totals.png


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-865079245

[-- Attachment #2: Type: text/html, Size: 1419 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

Master version seems to be OK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-865156363

[-- Attachment #2: Type: text/html, Size: 1119 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

![test_totals](https://user-images.githubusercontent.com/6944552/122792903-055fdb80-d2d4-11eb-81f3-58fe99f8731f.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-865156450

[-- Attachment #2: Type: text/html, Size: 1400 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Dave Täht]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

What is causing the 3000ms!!!! spikes in your test???

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-865436922

[-- Attachment #2: Type: text/html, Size: 1142 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Hello, Dave.

It's not a network issue. Bluetooth/Wi-Fi scanning cause these spikes. But honestly, I did a lot of research about current Android network kitchen. There are a lot of to improve. You see a test results of SberDevices SberBox early release (unpatched firmware). 
Current release is better a lot, because we did so much work to decrease latency and improve stability of Wi-Fi connection. I can say that scanning and roaming are two main diseases of android TV boxes/sticks. RTT could be up to 2000+ms. We can discuss it in the mailing list, but not here =)

Hope to share soon our results and Flent extensions for Android devices.

Actually, It's a good chance to say thank you, because some years ago your articles inspired me to learn more about traffic and queues.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-866002891

[-- Attachment #2: Type: text/html, Size: 1889 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

@tohojo 

Than you very much. Master version works perfectly.
Is it a good approach to make a minor release 2.0.1 without this issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-866915887

[-- Attachment #2: Type: text/html, Size: 1441 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Toke Høiland-Jørgensen]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

"Kirill Lukonin (EvilWirelessMan)" ***@***.***> writes:

> @tohojo 
>
> Than you very much. Master version works perfectly.
> Is it a good approach to make a minor release 2.0.1 without this
> issue?

Yeah, I guess a 2.0.1 release would be in order :)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867542993

[-- Attachment #2: Type: text/html, Size: 1398 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Dave Täht]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

thx very much for absorbing my (our) work.

what's the wifi chipset in this device? (can I get one?) did you implement https://www.usenix.org/conference/atc17/technical-sessions/presentation/hoilan-jorgesen

yes, I had written about the impact of channel scans before over here: http://blog.cerowrt.org/post/disabling_channel_scans/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867648924

[-- Attachment #2: Type: text/html, Size: 1633 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Dave Täht]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

also try adding net.ipv4.tcp_ecn=1 to sysctl

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867650898

[-- Attachment #2: Type: text/html, Size: 1133 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Dave Täht]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

It looks like we lost the g+ thread but basically we suppressed channel scans if the existing rssi was < 80 or so.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867651681

[-- Attachment #2: Type: text/html, Size: 1206 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

@dtaht 

it's a BCM4359 with bcmdhd driver (amlogic fork).
FullMAC architecture doesn't let us use airtime fairness.
So we did some job to decrease buffering inside the driver, we turned off power_save, roaming, periodic scans, background scanning.
We also use a combination of  fq_codel qdisc for wlan0 interface and BBR tcp congestion algo.

bcmdhd driver do some weird things. According to my limited understanding tx_glom and rx_glom work independently from kernel scatter-gather mechanism. So a bunch of tx frames would be splitted and aligned according to tx_glom bucket size every time we try to send something. 
This chip uses single queue for tx and rx, so according to it's architecture there is no way to achieve low delay with medium and heavy traffic scenarios.
Nowadays many android devices use this driver without any optimizations. And it works awful with pfifofast qdisc which is default for android. 
So much to improve...

P.S.
It looks like the default fq_codel interval (100ms) is not enough for mobile devices in some scenarios.
300ms ought to be enough for everybody. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867736262

[-- Attachment #2: Type: text/html, Size: 2434 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Kirill Lukonin (EvilWirelessMan)]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

`thx very much for absorbing my (our) work.`

@tohojo @dtaht 
I'm a big fan of your work for a long time)

Proofs:
https://ostconf.com/system/attachments/files/000/001/204/original/5_Lukonin_Kirill.pdf?1479120815
https://youtu.be/S8hYxAV8ElI?t=108
https://t.me/EvilWirelessMan/591

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867747905

[-- Attachment #2: Type: text/html, Size: 2078 bytes --]

[Flent-users] Re: [tohojo/flent] Plots are broken somehow (#227)

[Dave Täht]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

can you email me, I have something in the works you are going to *love* (davet AT teklibre.net)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/227#issuecomment-867783987

[-- Attachment #2: Type: text/html, Size: 1191 bytes --]