* Re: [Flent-users] [tohojo/flent] ss_iterate.sh yields corrupted output (#204) [not found] <tohojo/flent/issues/204@github.com> @ 2020-04-26 10:38 ` Toke Høiland-Jørgensen 2020-04-26 10:41 ` Toke Høiland-Jørgensen 2020-04-26 22:48 ` Toke Høiland-Jørgensen 2 siblings, 0 replies; 3+ messages in thread From: Toke Høiland-Jørgensen @ 2020-04-26 10:38 UTC (permalink / raw) To: tohojo/flent; +Cc: Subscribed [-- Attachment #1.1: Type: text/plain, Size: 1839 bytes --] Olivier Tilmans <notifications@github.com> writes: > I am running on a pretty-much bare host, where I have > ```bash > $ ss -V > ss utility, iproute2-ss191125 > ``` > > It turns out that when `ss_iterate.sh` runs `ss -ntp [...]`, `ss` does > not output a new line at the very end. This causes `ss_iterate.sh` to > collate the output with the `Time` field, resulting in the socket stat > records being all empty as the runner fails to parse a timestamp. Thank you for the report! I seems this was already fixed in iproute2 - see commit: 9eee92a41ae6 ("ss: fix end-of-line printing in misc/ss.c") This is dated Dec 4th, 2019, so I guess it's just after the version you're running. > I resolved this locally by tweaking `ss_iterate.sh` to output a new > line between w/e output ss prints, and the timestamp, i.e., I changed > the command string generation to: > > ```diff > command_string=$(cat <<EOF > for i in \$(seq $count); do > ss -t -i -p -n state connected "dst $target $filter" > + echo '' > date '+Time: %s.%N'; > echo "---"; > sleep $interval || exit 1; > done > EOF > ) > ``` > > I don't have the time to test whether this would have any impact on > hosts where `ss` prints a proper ouput, hence why this is not a PR. An > alternate way could be to put the timestamp generation _before_ the > invocation of `ss`. In both cases, the only issue would be if the > output was parsed without regex--which did not seem to be the case > from a quick glance. Yeah, the Flent parser for Ss output is entirely regex-based, so it just needs the timestamp at the beginning of a line. So I'm fine with adding your change as well :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/issues/204#issuecomment-619526509 [-- Attachment #1.2: Type: text/html, Size: 3098 bytes --] [-- Attachment #2: Type: text/plain, Size: 151 bytes --] _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Flent-users] [tohojo/flent] ss_iterate.sh yields corrupted output (#204) [not found] <tohojo/flent/issues/204@github.com> 2020-04-26 10:38 ` [Flent-users] [tohojo/flent] ss_iterate.sh yields corrupted output (#204) Toke Høiland-Jørgensen @ 2020-04-26 10:41 ` Toke Høiland-Jørgensen 2020-04-26 22:48 ` Toke Høiland-Jørgensen 2 siblings, 0 replies; 3+ messages in thread From: Toke Høiland-Jørgensen @ 2020-04-26 10:41 UTC (permalink / raw) To: tohojo/flent; +Cc: Subscribed [-- Attachment #1.1: Type: text/plain, Size: 239 bytes --] Closed #204 via 7cd5c3aa2dccf30957423013da2f0fc223d03dca. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/issues/204#event-3272803966 [-- Attachment #1.2: Type: text/html, Size: 1701 bytes --] [-- Attachment #2: Type: text/plain, Size: 151 bytes --] _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Flent-users] [tohojo/flent] ss_iterate.sh yields corrupted output (#204) [not found] <tohojo/flent/issues/204@github.com> 2020-04-26 10:38 ` [Flent-users] [tohojo/flent] ss_iterate.sh yields corrupted output (#204) Toke Høiland-Jørgensen 2020-04-26 10:41 ` Toke Høiland-Jørgensen @ 2020-04-26 22:48 ` Toke Høiland-Jørgensen 2 siblings, 0 replies; 3+ messages in thread From: Toke Høiland-Jørgensen @ 2020-04-26 22:48 UTC (permalink / raw) To: tohojo/flent; +Cc: Subscribed [-- Attachment #1.1: Type: text/plain, Size: 417 bytes --] \r \r On 26 April 2020 21:23:10 CEST, "Dave Täht" <notifications@github.com> wrote:\r >I note if you are running into heisenbugs, patches exist for both tc\r >and ss to let it poll on an interval. \r \r Exist where?\r \r \r -- \r You are receiving this because you are subscribed to this thread.\r Reply to this email directly or view it on GitHub:\r https://github.com/tohojo/flent/issues/204#issuecomment-619636898 [-- Attachment #1.2: Type: text/html, Size: 1393 bytes --] [-- Attachment #2: Type: text/plain, Size: 151 bytes --] _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-26 22:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <tohojo/flent/issues/204@github.com> 2020-04-26 10:38 ` [Flent-users] [tohojo/flent] ss_iterate.sh yields corrupted output (#204) Toke Høiland-Jørgensen 2020-04-26 10:41 ` Toke Høiland-Jørgensen 2020-04-26 22:48 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox