From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.4 Received: from mail.toke.dk by mail.toke.dk with LMTP id xW4xGed/qF4b7wUAOr1fkg (envelope-from ) for ; Tue, 28 Apr 2020 21:11:35 +0200 Authentication-Results: mail.toke.dk; none (SPF check N/A for local connections - client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=fyuzbf33 Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id 40D17731183 for ; Tue, 28 Apr 2020 21:11:34 +0200 (CEST) Received: from [::1] (port=52084 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.93) (envelope-from ) id 1jTVdk-007ZtX-R3; Tue, 28 Apr 2020 22:11:32 +0300 Received: from out-23.smtp.github.com ([192.30.252.206]:51441) by web6.sd.eurovps.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jTVdd-007Zn9-Tn for flent-users@flent.org; Tue, 28 Apr 2020 22:11:31 +0300 Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id 8C0CC661EED for ; Tue, 28 Apr 2020 12:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588101044; bh=Kp2vr3mJ+abTDJs4BzhA/vq3mTS4VvsXVTCIOs3u06k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fyuzbf33xWoHjeabXs+WVAHcC7VjyXqoqcePFRFE3Epbi8lfMFjmITPW3GfguYlSd oE47fnl6jFgG9361ObcUK6XrBBXcWombq5xRbbk4YpFH26JQGLQu6wg757nN0KiRje POqYsUgYMk8JWSKeZ4FOALajNl8EfPCf6kCWNajE= Date: Tue, 28 Apr 2020 12:10:44 -0700 From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: comment X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: Re: [Flent-users] [tohojo/flent] Customized test displaying error (#203) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.29 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Comment , flent-users Content-Type: multipart/mixed; boundary="===============7930845448861970942==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============7930845448861970942== Content-Type: multipart/alternative; boundary="--==_mimepart_5ea87fb47d5f9_2d633fc3034cd96013374"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5ea87fb47d5f9_2d633fc3034cd96013374 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit olg33 writes: >> Where are you getting these values from? Tcpdump? The labels are not sent on the wire at all (and nothing you can do to change that). > >> The 'labels' parameter should set the plot labels on the Flent plots, though... > > It's Wireshark and I'm only showing the relevant information. Ok good to know, the labels are just for displaying purpose, in fact I'm not too worried about the labels as I'm feeding the output to Netdata for graphing. > > My main concern is that (at least for me) the new MARKING_MAP doesn't seem to be working. > MARKING_MAP = { > '10': 0x28, > '11': 0x2c, > '13': 0x34, > '15': 0x38, > '17': 0x40, > '19': 0x4c, > '20': 0x50, > '21': 0x54, > '23': 0x5c, > '25': 0x64, > '27': 0x6c, > '29': 0x74} > If I run the following test (after editing the MARKING_MAP with custom settings): > >> ./run-flent rrul_var --test-parameter bidir_streams=5 --test-parameter markings=10,13,15,17,19 -H 192.168.9.13 -l 60 > > I only see packets marked with Hex values that are not part of the map: > >> Differentiated Services Field: 0x08 (DSCP: Unknown, ECN: Not-ECT) > Differentiated Services Field: 0x10 (DSCP: Unknown, ECN: Not-ECT) > Differentiated Services Field: 0x0c (DSCP: Unknown, ECN: Not-ECT) Ohh, right, the markings_map is only used for irtt and iperf, for netperf the values are just passed directly through. Totally forgot about that. I guess I could fix that, but TBH I'm not terribly keen on supporting non-standard diffserv markings in this way. You could do this yourself, though; if you replace this line in NetperfDemoRunner (in runners.py): args['marking'] = "-Y {0}".format(args['marking']) with: args['marking'] = self.parse_marking(args['marking'], "-Y {0}") that should do the trick. You'll lose the support for different markings on downstream and upstream, but that won't work with the 'markings' test parameter anyway :) > That's why I do believe I'm doing something wrong or maybe there was > an additional step other than just editing the Marking_Map. > > In fact, using just the hex values works for me, but if someone else > that only knows the custom dscp values want to test, that will fail, > that's why I'd like to be able to feed those values. Just checking, but when you say "someone else" you mean someone else who has access to that same system, right? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/issues/203#issuecomment-620800380 ----==_mimepart_5ea87fb47d5f9_2d633fc3034cd96013374 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

olg33 <notifications@github.com> writes:

>> Where are you getting these values from? Tcpdump? The labels are not sent on the wire at all (and nothing you can do to change that).
>
>> The 'labels' parameter should set the plot labels on the Flent plots, though...
>
> It's Wireshark and I'm only showing the relevant information. Ok good to know, the labels are just for displaying purpose, in fact I'm not too worried about the labels as I'm feeding the output to Netdata for graphing.
>
> My main concern is that (at least for me) the new MARKING_MAP doesn't seem to be working.
> MARKING_MAP = {
> '10': 0x28,
> '11': 0x2c,
> '13': 0x34,
> '15': 0x38,
> '17': 0x40,
> '19': 0x4c,
> '20': 0x50,
> '21': 0x54,
> '23': 0x5c,
> '25': 0x64,
> '27': 0x6c,
> '29': 0x74}
> If I run the following test (after editing the MARKING_MAP with custom settings):
>
>> ./run-flent rrul_var --test-parameter bidir_streams=5 --test-parameter markings=10,13,15,17,19 -H 192.168.9.13 -l 60
>
> I only see packets marked with Hex values that are not part of the map:
>
>> Differentiated Services Field: 0x08 (DSCP: Unknown, ECN: Not-ECT)
> Differentiated Services Field: 0x10 (DSCP: Unknown, ECN: Not-ECT)
> Differentiated Services Field: 0x0c (DSCP: Unknown, ECN: Not-ECT)

Ohh, right, the markings_map is only used for irtt and iperf, for
netperf the values are just passed directly through. Totally forgot
about that. I guess I could fix that, but TBH I'm not terribly keen on
supporting non-standard diffserv markings in this way.

You could do this yourself, though; if you replace this line in
NetperfDemoRunner (in runners.py):

args['marking'] = "-Y {0}".format(args['marking'])

with:

args['marking'] = self.parse_marking(args['marking'], "-Y {0}")

that should do the trick. You'll lose the support for different markings
on downstream and upstream, but that won't work with the 'markings' test
parameter anyway :)

> That's why I do believe I'm doing something wrong or maybe there was
> an additional step other than just editing the Marking_Map.
>
> In fact, using just the hex values works for me, but if someone else
> that only knows the custom dscp values want to test, that will fail,
> that's why I'd like to be able to feed those values.

Just checking, but when you say "someone else" you mean someone else who
has access to that same system, right?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5ea87fb47d5f9_2d633fc3034cd96013374-- --===============7930845448861970942== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============7930845448861970942==--