From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from mail.toke.dk by mail.toke.dk with LMTP id 4zbzLgISfF2JCAAAOr1fkg (envelope-from ) for ; Sat, 14 Sep 2019 00:02:42 +0200 Authentication-Results: mail.toke.dk; none (SPF check N/A for local connections - client-ip=77.235.54.103; helo=web6.sd.eurovps.com; envelope-from=flent-users-bounces@flent.org; receiver=) Authentication-Results: mail.toke.dk; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=xXaoakM4 Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id 9C99866786F for ; Sat, 14 Sep 2019 00:02:40 +0200 (CEST) Received: from [::1] (port=48976 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.92) (envelope-from ) id 1i8teJ-00Ef3U-JF; Sat, 14 Sep 2019 01:02:39 +0300 Received: from out-5.smtp.github.com ([192.30.252.196]:58873) by web6.sd.eurovps.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i8teB-00Eexe-63 for flent-users@flent.org; Sat, 14 Sep 2019 01:02:37 +0300 Date: Fri, 13 Sep 2019 15:01:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568412110; bh=CizLLrmClNGkKux4ZK6OU5IxhbcSHPq/pL+hy1Q0Nng=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xXaoakM42Pkn0S8xJM5Gwd+u5MSahWf0is+Pg6JwMuOIU9ma3UUyyn/a04bEJyXOe fUq8GXrjNszkN/b/ojljN6uNERjZyIMWjjmfTN0JkiyZPT3JNdW3lW37zLoQM9SNgR bkW3DA8uHPoZSTlgXzFVMT20/9d+b435p1fX8sjA= From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org Subject: Re: [Flent-users] [tohojo/flent] Charting ping_hosts (#181) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.27 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Subscribed Content-Type: multipart/mixed; boundary="===============1028833110695115243==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============1028833110695115243== Content-Type: multipart/alternative; boundary="--==_mimepart_5d7c11ce21d60_77ad3fb93c8cd964142822"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_5d7c11ce21d60_77ad3fb93c8cd964142822 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Rich Brown writes: > I don't pretend to understand the metadata - there is a lot stuff in > the JSON file - but I don't think including the information in the > filename would be necessary. > > I don't foresee a transition problem here. Flent can continue to > default to using the -H host for its latency measurements. The new > version's results should be comparable to results from a months-ago > run with the same network conditions. > > In the case when someone explicitly uses the > --use_this_host_for_default_latency option, Flent will of course > preserve that flag in some new metadata and the charts will look > different. But the person running the test will know about that flag > and can take that into account. > > (Or am I missing your point...) Thanks. The point is that if you have two data files, one where the flag was used and one where it wasn't, and then create a plot with both of those data files... Then the plot will show two wildly different ping graphs for what is ostensibly the same test. Yes, we can save it in the data file, but we also want it to be obvious from the plots themselves... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/issues/181#issuecomment-531404864 ----==_mimepart_5d7c11ce21d60_77ad3fb93c8cd964142822 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Rich Brown <notifications@github.com> writes:

> I don't pretend to understand the metadata - there is a lot stuff in
> the JSON file - but I don't think including the information in the
> filename would be necessary.
>
> I don't foresee a transition problem here. Flent can continue to
> default to using the -H host for its latency measurements. The new
> version's results should be comparable to results from a months-ago
> run with the same network conditions.
>
> In the case when someone explicitly uses the
> --use_this_host_for_default_latency option, Flent will of course
> preserve that flag in some new metadata and the charts will look
> different. But the person running the test will know about that flag
> and can take that into account.
>
> (Or am I missing your point...) Thanks.

The point is that if you have two data files, one where the flag was
used and one where it wasn't, and then create a plot with both of those
data files... Then the plot will show two wildly different ping graphs
for what is ostensibly the same test.

Yes, we can save it in the data file, but we also want it to be obvious
from the plots themselves...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5d7c11ce21d60_77ad3fb93c8cd964142822-- --===============1028833110695115243== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============1028833110695115243==--