Flent-users discussion archives
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <notifications@github.com>
To: tohojo/flent <flent@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [Flent-users] [tohojo/flent] Charting ping_hosts (#181)
Date: Fri, 13 Sep 2019 15:01:50 -0700	[thread overview]
Message-ID: <tohojo/flent/issues/181/531404864@github.com> (raw)
In-Reply-To: <tohojo/flent/issues/181@github.com>


[-- Attachment #1.1: Type: text/plain, Size: 1339 bytes --]

Rich Brown <notifications@github.com> writes:

> I don't pretend to understand the metadata - there is a lot stuff in
> the JSON file - but I don't think including the information in the
> filename would be necessary.
>
> I don't foresee a transition problem here. Flent can continue to
> default to using the -H host for its latency measurements. The new
> version's results should be comparable to results from a months-ago
> run with the same network conditions.
>
> In the case when someone explicitly uses the
> --use_this_host_for_default_latency option, Flent will of course
> preserve that flag in some new metadata and the charts will look
> different. But the person running the test will know about that flag
> and can take that into account.
>
> (Or am I missing your point...) Thanks.

The point is that if you have two data files, one where the flag was
used and one where it wasn't, and then create a plot with both of those
data files... Then the plot will show two wildly different ping graphs
for what is ostensibly the same test.

Yes, we can save it in the data file, but we also want it to be obvious
from the plots themselves...


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/issues/181#issuecomment-531404864

[-- Attachment #1.2: Type: text/html, Size: 2874 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Flent-users mailing list
Flent-users@flent.org
http://flent.org/mailman/listinfo/flent-users_flent.org

  parent reply	other threads:[~2019-09-13 22:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 15:39 Rich Brown
2019-09-11 11:54 ` Rich Brown
2019-09-11 12:05 ` Rich Brown
2019-09-11 12:07 ` Toke Høiland-Jørgensen
2019-09-11 12:17 ` Rich Brown
2019-09-11 15:15 ` Toke Høiland-Jørgensen
2019-09-11 16:12 ` Rich Brown
2019-09-11 17:27 ` Toke Høiland-Jørgensen
2019-09-11 18:13 ` Rich Brown
2019-09-13 16:27 ` Toke Høiland-Jørgensen
2019-09-13 17:13 ` Rich Brown
2019-09-13 22:01 ` Toke Høiland-Jørgensen [this message]
2019-09-14  1:45 ` Rich Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.flent.org/postorius/lists/flent-users.flent.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tohojo/flent/issues/181/531404864@github.com \
    --to=notifications@github.com \
    --cc=flent@noreply.github.com \
    --cc=reply+AHVNJP6BVDCIU2LZQWQR3GV3RFCE5EVBNHHB2T4L5Y@reply.github.com \
    --cc=subscribed@noreply.github.com \
    --subject='Re: [Flent-users] [tohojo/flent] Charting ping_hosts (#181)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox