Pete Heist &lt;notifications@github.com&gt; writes:<br>
<br>
&gt;&gt; On Nov 20, 2017, at 9:58 PM, Toke Høiland-Jørgensen &lt;notifications@github.com&gt; wrote:<br>
&gt;&gt; Okay, testable code in the runner-refactor branch.<br>
&gt;&gt; <br>
&gt;&gt; Ended up doing a fairly involved refactoring of how runners work with<br>
&gt;&gt; data; which is good, as the new way to structure things makes a lot more<br>
&gt;&gt; sense in general; but it did mean I had to change the data format, so<br>
&gt;&gt; quite a few places this can break. So testing appreciated, both for<br>
&gt;&gt; running new tests, and for plotting old data files.<br>
&gt;&gt; <br>
&gt; Awesome, I’m sure it could take some shaking out. I tried an rrul_be<br>
&gt; test on the runner-refactor branch...<br>
<br>
Ha! Epic fail! :D<br>
<br>
Well, I only just managed to finish writing the code and unbreaking the<br>
CI tests; didn&#39;t actually get around to running any tests. I&#39;ve fixed<br>
those two errors, and am running a full test run on my testbed now...<br>
<br>
-Toke<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/tohojo/flent/issues/106#issuecomment-345985779">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AerUv5zt-8l3W6UO6cpOdZjyl0xstrAAks5s4qeXgaJpZM4MpJAm">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AerUvxpkzJtqERBEV3tHREwEY5j_lvB_ks5s4qeXgaJpZM4MpJAm.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/tohojo/flent/issues/106#issuecomment-345985779"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tohojo/flent","title":"tohojo/flent","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/tohojo/flent"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tohojo in #106: Pete Heist \u003cnotifications@github.com\u003e writes:\n\n\u003e\u003e On Nov 20, 2017, at 9:58 PM, Toke Høiland-Jørgensen \u003cnotifications@github.com\u003e wrote:\n\u003e\u003e Okay, testable code in the runner-refactor branch.\n\u003e\u003e \n\u003e\u003e Ended up doing a fairly involved refactoring of how runners work with\n\u003e\u003e data; which is good, as the new way to structure things makes a lot more\n\u003e\u003e sense in general; but it did mean I had to change the data format, so\n\u003e\u003e quite a few places this can break. So testing appreciated, both for\n\u003e\u003e running new tests, and for plotting old data files.\n\u003e\u003e \n\u003e Awesome, I’m sure it could take some shaking out. I tried an rrul_be\n\u003e test on the runner-refactor branch...\n\nHa! Epic fail! :D\n\nWell, I only just managed to finish writing the code and unbreaking the\nCI tests; didn't actually get around to running any tests. I've fixed\nthose two errors, and am running a full test run on my testbed now...\n\n-Toke\n"}],"action":{"name":"View Issue","url":"https://github.com/tohojo/flent/issues/106#issuecomment-345985779"}}}</script>