Pete Heist &lt;notifications@github.com&gt; writes:<br>
<br>
&gt;&gt; On Nov 16, 2017, at 2:07 PM, Toke Høiland-Jørgensen &lt;notifications@github.com&gt; wrote:<br>
&gt;&gt; <br>
&gt;&gt; Pete Heist &lt;notifications@github.com&gt; writes:<br>
&gt;&gt; <br>
&gt;&gt; &gt;&gt; On Nov 16, 2017, at 1:48 PM, Toke Høiland-Jørgensen &lt;notifications@github.com&gt; wrote:<br>
&gt;&gt; &gt;&gt; <br>
&gt;&gt; &gt;&gt; &gt; The handshake takes up to 15 seconds to complete (delays of 1, 2, 4<br>
&gt;&gt; &gt;&gt; &gt; and 8 seconds waiting for a reply), so not having irtt on the server<br>
&gt;&gt; &gt;&gt; &gt; will mean a 15 second wait. Do you think it’s ok to keep that fixed?<br>
&gt;&gt; &gt;&gt; <br>
&gt;&gt; &gt;&gt; Hmm, waiting 15 seconds before starting a test is probably a bit much.<br>
&gt;&gt; &gt;&gt; For the test, I&#39;d say don&#39;t retransmit and make the wait configurable?<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; How about re-transmit but once per second with a flag for the number<br>
&gt;&gt; &gt; of times to try, plus I’d probably limit it to some maximum. If<br>
&gt;&gt; &gt; there’s no retransmit you might see fallbacks due to packet loss more<br>
&gt;&gt; &gt; than you’d want.<br>
&gt;&gt; <br>
&gt;&gt; Sure, that works. Or make the interval a flag as well, maybe?<br>
&gt;<br>
&gt; Yeah, I was thinking of making the handshake waits configurable<br>
&gt; anyway, so I’ll probably do that and I think it will be flexible<br>
&gt; enough for what’s needed. Will update when it’s ready…<br>
<br>
Cool :)<br>
<br>
-Toke<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/tohojo/flent/issues/106#issuecomment-344919974">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AerUv3q4FBpLjpdV3ZARsFwA30viMQPwks5s3DYugaJpZM4MpJAm">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AerUv8NMet5OPV4vDApbBMqMg6Nllgh3ks5s3DYugaJpZM4MpJAm.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/tohojo/flent/issues/106#issuecomment-344919974"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tohojo/flent","title":"tohojo/flent","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/tohojo/flent"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tohojo in #106: Pete Heist \u003cnotifications@github.com\u003e writes:\n\n\u003e\u003e On Nov 16, 2017, at 2:07 PM, Toke Høiland-Jørgensen \u003cnotifications@github.com\u003e wrote:\n\u003e\u003e \n\u003e\u003e Pete Heist \u003cnotifications@github.com\u003e writes:\n\u003e\u003e \n\u003e\u003e \u003e\u003e On Nov 16, 2017, at 1:48 PM, Toke Høiland-Jørgensen \u003cnotifications@github.com\u003e wrote:\n\u003e\u003e \u003e\u003e \n\u003e\u003e \u003e\u003e \u003e The handshake takes up to 15 seconds to complete (delays of 1, 2, 4\n\u003e\u003e \u003e\u003e \u003e and 8 seconds waiting for a reply), so not having irtt on the server\n\u003e\u003e \u003e\u003e \u003e will mean a 15 second wait. Do you think it’s ok to keep that fixed?\n\u003e\u003e \u003e\u003e \n\u003e\u003e \u003e\u003e Hmm, waiting 15 seconds before starting a test is probably a bit much.\n\u003e\u003e \u003e\u003e For the test, I'd say don't retransmit and make the wait configurable?\n\u003e\u003e \u003e\n\u003e\u003e \u003e How about re-transmit but once per second with a flag for the number\n\u003e\u003e \u003e of times to try, plus I’d probably limit it to some maximum. If\n\u003e\u003e \u003e there’s no retransmit you might see fallbacks due to packet loss more\n\u003e\u003e \u003e than you’d want.\n\u003e\u003e \n\u003e\u003e Sure, that works. Or make the interval a flag as well, maybe?\n\u003e\n\u003e Yeah, I was thinking of making the handshake waits configurable\n\u003e anyway, so I’ll probably do that and I think it will be flexible\n\u003e enough for what’s needed. Will update when it’s ready…\n\nCool :)\n\n-Toke\n"}],"action":{"name":"View Issue","url":"https://github.com/tohojo/flent/issues/106#issuecomment-344919974"}}}</script>