From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.toke.dk X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.1 Received: from mail.toke.dk by mail.toke.dk with LMTP id EFyCFk/W5FlzBAAAGYNwYA for ; Mon, 16 Oct 2017 17:54:55 +0200 Received: from web6.sd.eurovps.com (web6.sd.eurovps.com [77.235.54.103]) by mail.toke.dk (Postfix) with ESMTPS id D239A1FB34A for ; Mon, 16 Oct 2017 17:54:52 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=fail reason="key not found in DNS" (0-bit key) header.d=flent.org header.i=@flent.org header.b=PrbGkfgT; dkim=fail reason="signature verification failed" (1024-bit key) header.d=github.com header.i=@github.com header.b=wzctj7q2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=flent.org; s=default; h=Sender:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Mime-Version: References:In-Reply-To:Message-ID:To:From:Date:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wz+4DHLIL/P1ItF8K/rK2t8oPfhwr0BxwCwyItORTfY=; b=PrbGkfgTKqbH6xnLozeb0RfV8v OenrQGGMTM0VXtVMXQkIPMKewJSFboc6bQsLshQQUgxkoYE0KXPZLJ7UhDKmg0iCiB5C+qvMoueC5 xv4cT8t/oyn95tcPGMT+jRAwWYgS4lnfFZrTL5Pa8+d6rItMBB6HtqYcikGndUSSdcunrQi6mSbY7 K+V/glU0930+h4F13g0T5KF9fAZEMBpkQ+YAqcFhaRvMwAJXwqv6pHiEhTknxEyQD5Sv96U404WAW JNO0RExrlfan5hoc//iqh4cyVjiWeEQUM8JwolP0RwNFc5Z9Kr4fhDH1lrSPWRzbdx9YWn+YDgLVm TA93TmNw==; Received: from [::1] (port=54160 helo=web6.sd.eurovps.com) by web6.sd.eurovps.com with esmtp (Exim 4.89) (envelope-from ) id 1e47j9-002YPT-T4; Mon, 16 Oct 2017 18:54:51 +0300 Received: from o6.sgmail.github.com ([192.254.113.101]:11253) by web6.sd.eurovps.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1e47j4-002YGz-NF for flent-users@flent.org; Mon, 16 Oct 2017 18:54:49 +0300 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=FYMO1OXtjgcmpF+RyQ//AmVN3pI=; b=wzctj7q2TEfetCRJ o8tOSs/H4La8qTcPCREQESvWHXH2OkMLfCHL5VIXtFLqzDb/ATwrDecZM/n2OCq9 brSubJlcBoYT66I528vfVy+nGh6U2gdzO9W9ldN553e2d6OR4ZkZeSP18ZN83wL2 sqLZxayLUyfCph4tBIMuR7l2vjA= Received: by filter0089p1iad2.sendgrid.net with SMTP id filter0089p1iad2-340-59E4D61B-B 2017-10-16 15:54:03.1558396 +0000 UTC Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0020p1iad2.sendgrid.net (SG) with ESMTP id z3QZC2wrRmSJVomu_exh9A for ; Mon, 16 Oct 2017 15:54:03.202 +0000 (UTC) Date: Mon, 16 Oct 2017 15:54:03 +0000 (UTC) From: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= To: tohojo/flent Message-ID: In-Reply-To: References: Mime-Version: 1.0 Precedence: list X-GitHub-Sender: tohojo X-GitHub-Recipient: flent-users X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: flent-users@flent.org X-SG-EID: IRsowsd9yCOJafMG0EWGsh26xBq50lgDrxWUlCCqUntKGy8r8gb6rQQSS/k3M+kmENKboDeLRr0NGI IQ5TNMJxel8qbtVLeifBcU4RPFacDVRE3SMJZTZn1wIRalb4C5h+Vi1DKx6A4rFyim1eFQ6bCPRmSe CA6KeHAlAMMbFUvxztAyJT6wDwJ8baLSPpWEl0JphuvpCiTtsYht95ysf1PJ8Aile0n3L231AaAouK Z6B54vKWk50jIVe77RLjE4 Subject: Re: [Flent-users] [tohojo/flent] packet loss stats (#106) X-BeenThere: flent-users@flent.org X-Mailman-Version: 2.1.23 List-Id: Flent discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: tohojo/flent Cc: Subscribed Content-Type: multipart/mixed; boundary="===============8859860099909319082==" Errors-To: flent-users-bounces@flent.org Sender: "Flent-users" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - web6.sd.eurovps.com X-AntiAbuse: Original Domain - toke.dk X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - flent.org X-Get-Message-Sender-Via: web6.sd.eurovps.com: acl_c_authenticated_local_user: mailman/mailman X-Authenticated-Sender: web6.sd.eurovps.com: mailman@flent.org --===============8859860099909319082== Content-Type: multipart/alternative; boundary="--==_mimepart_59e4d61b1eee_3d313fe0df724f342912b"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_59e4d61b1eee_3d313fe0df724f342912b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Pete Heist writes: > Thanks! I made most of your changes (-o was particularly broken, so > this is a better solution), except: Cool! > - I'm still thinking about whether to default durations to seconds or > not. I'm using Go's default duration flag parsing, and I like the > explicitness of seeing the units. Hmm, I see your point about explicit being better, but again it's surprising. A compromise could be to detect it and warn the user explicitly (i.e., instead of just printing out the whole help message you could go "you specified a unitless duration. did you mean Xs?"). > - I like that the JSON is written even after ctrl-C, so that > interrupting a long test doesn't mean you lose all your results. But > maybe if you're sending output to stdout, it's not a good idea (or > even breaks some convention?) This is a trade-off between not accidentally dropping data and not having to clean up after a tool that you clearly just interrupted. I would definitely say don't output the JSON to STDOUT when interrupted (but the stats are fine). Writing to file, hmm, I dunno... > I changed it to ping-like behavior (although there is now -q for no > per-packet results and -qq for no output at all). But just to explain > the thought process, I felt that the default of five round trips in > one second, which produces a reasonable approximation of all relevant > stats in a short period of time, was better than waiting in > anticipation for the next one second ping. In one second you could > already be reviewing stats. :) Also, since I think IRTT will be > typically used for lower intervals than ping, not defaulting to > per-packet output made sense to me. I don't need to do things just > because of tradition. **However**, I took your advice because we're > all so accustomed to ping for so many years now, that what I like as a > default might be uncomfortable or annoying to others, and I don't wish > for people to get that feeling. Right, I see your point. But yeah, I think having it be an alternative to ping for interactive use is a valid use case, and for that mirroring what people are used to is probably better. Besides, if someone wants to measure things more accurately, they are probably going to be fiddling with the options anyways... > Also, If there's a reason I should do my tests with iperf2 instead, > I'm all ears, as I'm a "scientist," not attached to my own work. :) I haven't tried out the iperf code yet, but from the discussion on the list yours has several features that iperf is lacking, most notably the handshake (but also way more detailed statistics). So I definitely don't think your efforts are wasted :) -Toke -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tohojo/flent/issues/106#issuecomment-336931544 ----==_mimepart_59e4d61b1eee_3d313fe0df724f342912b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Pete Heist <notifications@github.com> writes:

> Thanks! I made most of your changes (-o was particularly broken, so
> this is a better solution), except:

Cool!

> - I'm still thinking about whether to default durations to seconds= or
> not. I'm using Go's default duration flag parsing, and I like = the
> explicitness of seeing the units.

Hmm, I see your point about explicit being better, but again it's
surprising. A compromise could be to detect it and warn the user
explicitly (i.e., instead of just printing out the whole help message
you could go "you specified a unitless duration. did you mean Xs?"= ;).

> - I like that the JSON is written even after ctrl-C, so that
> interrupting a long test doesn't mean you lose all your results. B= ut
> maybe if you're sending output to stdout, it's not a good idea= (or
> even breaks some convention?)

This is a trade-off between not accidentally dropping data and not
having to clean up after a tool that you clearly just interrupted. I
would definitely say don't output the JSON to STDOUT when interrupted (but the stats are fine). Writing to file, hmm, I dunno...

> I changed it to ping-like behavior (although there is now -q for no
> per-packet results and -qq for no output at all). But just to explain<= br> > the thought process, I felt that the default of five round trips in
> one second, which produces a reasonable approximation of all relevant<= br> > stats in a short period of time, was better than waiting in
> anticipation for the next one second ping. In one second you could
> already be reviewing stats. :) Also, since I think IRTT will be
> typically used for lower intervals than ping, not defaulting to
> per-packet output made sense to me. I don't need to do things just=
> because of tradition. **However**, I took your advice because we'r= e
> all so accustomed to ping for so many years now, that what I like as a=
> default might be uncomfortable or annoying to others, and I don't = wish
> for people to get that feeling.

Right, I see your point. But yeah, I think having it be an alternative
to ping for interactive use is a valid use case, and for that mirroring
what people are used to is probably better. Besides, if someone wants to
measure things more accurately, they are probably going to be fiddling
with the options anyways...

> Also, If there's a reason I should do my tests with iperf2 instead= ,
> I'm all ears, as I'm a "scientist," not attached to = my own work. :)

I haven't tried out the iperf code yet, but from the discussion on the<= br> list yours has several features that iperf is lacking, most notably the
handshake (but also way more detailed statistics). So I definitely don'= t
think your efforts are wasted :)

-Toke

&mda= sh;
You are receiving this because you are subscribed to this thread.<= br />Reply to this email directly, view it on GitHub, or mute the thread.3D""

= ----==_mimepart_59e4d61b1eee_3d313fe0df724f342912b-- --===============8859860099909319082== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Flent-users mailing list Flent-users@flent.org http://flent.org/mailman/listinfo/flent-users_flent.org --===============8859860099909319082==--